[python] Fix git-lfs issue when cloning Geneformer #1150
Conversation
| @@ -33,7 +33,7 @@ jobs: | |||
| run: | | |||
| python -m pip install -U pip setuptools wheel | |||
| pip install --use-pep517 accumulation-tree # Geneformer dependency needs --use-pep517 for Cython | |||
| pip install -r ./api/python/cellxgene_census/scripts/requirements-dev.txt | |||
| GIT_CLONE_PROTECTION_ACTIVE=false pip install -r ./api/python/cellxgene_census/scripts/requirements-dev.txt | |||
There was a problem hiding this comment.
It looks like this fixes it! Or, at least it doesn't fail to install anymore.
Should this get a link to the issue in git-lfs here, or an issue tracking the removal of this workaround?
There was a problem hiding this comment.
I'm thinking that maybe these tests should not belong here, as the specific dependency is quite obscure (it even points to a specific commit). If we decide to purge them, this won't be needed, otherwise we should definitely create an issue.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1150 +/- ##
=======================================
Coverage 91.12% 91.12%
=======================================
Files 77 77
Lines 5857 5857
=======================================
Hits 5337 5337
Misses 520 520
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ebezzi
changed the title
Attemps to fix an issue caused by git-lfs which is used by Geneformer tests.