Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CLI argument to launch for switching between .X and .raw #689

Closed
sidneymbell opened this issue Apr 2, 2019 · 4 comments
Closed

Add CLI argument to launch for switching between .X and .raw #689

sidneymbell opened this issue Apr 2, 2019 · 4 comments
Assignees
Labels
discussion long running discussion, request for feedback

Comments

@sidneymbell
Copy link
Contributor

Thanks so much to @gokceneraslan (#676) and @Marius1311 (#542) for flagging the related issues of how to visualize .raw versus .X (and making it clear which one you're looking at!).

Making a new issue to offer a proposed solution for discussion.

It's rather confusing and/or misleading to visualize normalized and unnormalized values in the same view. One solution would be to toggle back and forth between viewing .raw and .X within the app (as suggested by @gokceneraslan :).

However, the frontend currently only accommodates a single matrix of values. Under the hood, toggling would be effectively the same as relaunching.

I'd propose to just add a command line argument to launch that allows the user to specify whether they want to load the raw count values from .raw or the normalized values from .X (the default).

Would this adequately solve the needs presented in #676 and #542? All feedback and thoughts welcome!

@csweaver csweaver added the discussion long running discussion, request for feedback label Apr 2, 2019
@Marius1311
Copy link

Dear @sidneymbell , that sounds good to me!

@gokceneraslan
Copy link
Contributor

gokceneraslan commented Apr 3, 2019

Sounds good to me, too. Ideally, the gene search should always be performed in .raw since gene subsetting in Scanpy (i.e. ad = ad[:, somegenes] or sc.pp.filter_genes or sc.pp.highly_variable_genes(subset=True)) filters out genes in X but always keep all genes in raw.X. But if it's challenging technically, specifying from the command line is also ok.

What about the layers? I think it also makes sense to select a layer from the command line. What do you think?

@alokito
Copy link

alokito commented Dec 4, 2019

Anecdotally some users say being able to toggle between raw and normalized values would be ideal, and that Seurat recommends performing differential expression analysis on the raw values.

@signechambers1
Copy link
Contributor

Fixed via #1030

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion long running discussion, request for feedback
Projects
None yet
Development

No branches or pull requests

7 participants