Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow launch to accept url too #815

Closed
csweaver opened this issue Jun 13, 2019 · 6 comments · Fixed by #920
Closed

Allow launch to accept url too #815

csweaver opened this issue Jun 13, 2019 · 6 comments · Fixed by #920
Assignees
Labels
enhancement system CLI, install, launch, etc.
Milestone

Comments

@csweaver
Copy link
Contributor

Allow cellxgene launch to accept a URL to a h5ad file, currently it only accepts file paths. This would simply be a convenience as it would just read the whole file from the url and not fancy streaming, etc.

(came from H2 planning)

@csweaver csweaver added enhancement system CLI, install, launch, etc. labels Jun 13, 2019
@sidneymbell
Copy link
Contributor

Jonah was chatting with a user this week, and they mentioned that this would be a big win. They have sensitive data that cannot be removed from the server, but that they would like to be able to explore by pointing cellxgene at the relevant URL.

@seve seve self-assigned this Jul 29, 2019
@bkmartinjr bkmartinjr added this to the 0.12.0 milestone Aug 8, 2019
@colinmegill
Copy link
Contributor

colinmegill commented Aug 8, 2019

@ambrosejcarr

@seve
Copy link
Member

seve commented Sep 3, 2019

Unless @bkmartinjr can complete this, I'd like to push this to a further release. I self-assigned this due to its potential grouping with #875

@bkmartinjr
Copy link
Contributor

bkmartinjr commented Sep 12, 2019

@sidneymbell - you said:

... sensitive data that cannot be removed from the server, but that they would like to be able to explore by pointing cellxgene at the relevant URL.

How would this work in practice? At a minimum, any data cellxgene presents to the user must be available in the browser -- with our current implementation, that also means the necessary data is proxied by the CLI/back-end. This means that it must be pulled (read) from the server by the CLI/backend, and sent to the browser/front-end.

Is the assumption that the sensitive parts of the data are not needed by cellxgene (for exploration)? Or simply did you mean "remove" as in "delete"? Or am I misunderstanding? TY!

[ps. in case this is just a miscommunication -- this feature is no substitute for implementing server-side auth and access control, on any repository managing restricted access data]

@sidneymbell
Copy link
Contributor

@bkmartinjr I believe he was describing limitations on copying/downloading the data to another machine.

I.e., the backend would need to read directly from the file that the URL points to, as opposed to downloading a local copy before ingesting.

@bkmartinjr
Copy link
Contributor

OK, tnx - but this doesn't address his security issues at all. Can you follow-up with him to clarify? (feel free to pull me in if it helps)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement system CLI, install, launch, etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants