Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add URL data locators to launch sub-command #920

Merged
merged 7 commits into from Sep 15, 2019

Conversation

bkmartinjr
Copy link
Contributor

Fixes #815

launch command now accepts URLs as well as local filesystem paths.

@bkmartinjr bkmartinjr changed the title [WIP] add URL data locators to launch Add URL data locators to launch sub-command Sep 13, 2019
Copy link

@liaprins-czi liaprins-czi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read the doc updates and successfully launched https://raw.githubusercontent.com/chanzuckerberg/cellxgene/master/example-dataset/pbmc3k.h5ad as exemplified in doc update. Looks good to me!

docs/faq.md Outdated Show resolved Hide resolved
Copy link
Contributor

@sidneymbell sidneymbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'll plan to test it a bit more next week w/ different data sources (e.g., S3).

@bkmartinjr bkmartinjr merged commit 20317fd into master Sep 15, 2019
@bkmartinjr bkmartinjr deleted the bkmartinjr/815-file-locators branch September 15, 2019 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow launch to accept url too
4 participants