Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use iptables to classify packets (#1031) #1038

Merged
merged 1 commit into from
Oct 13, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #1031 to release-1.0


Signed-off-by: Yang Keao keao.yang@yahoo.com

What problem does this PR solve?

#688 The default kernel of GKE is not built with CONFIG_NET_EMATCH and CONFIG_NET_EMATCH_IPSET so we cannot match ipset as a filter in tc.

This PR uses iptables -A TC-TABLES-0 -m set --match-set A dst -j CLASSIFY --set-class 3:4 -w 5 to replace it.

What is changed and how does it work?

Checklist

Tests

  • E2E test

I have run the e2e test on GKE, and it works well.

Signed-off-by: Yang Keao <keao.yang@yahoo.com>
@ti-srebot
Copy link
Contributor Author

/run-all-tests

Copy link
Contributor

@WangXiangUSTC WangXiangUSTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YangKeao
Copy link
Member

/merge

@ti-srebot
Copy link
Contributor Author

@YangKeao Oops! This PR requires at least 2 LGTMs to merge. The current number of LGTM is 0

Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YangKeao
Copy link
Member

/merge

@ti-srebot
Copy link
Contributor Author

@YangKeao Oops! This PR requires at least 2 LGTMs to merge. The current number of LGTM is 0

@YangKeao YangKeao merged commit 4f7c844 into chaos-mesh:release-1.0 Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug-fix A bug needs to be fixed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants