Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the chaos-mesh Helm repository #1061

Merged
merged 2 commits into from
Oct 16, 2020
Merged

Conversation

wstrm
Copy link
Contributor

@wstrm wstrm commented Oct 16, 2020

What problem does this PR solve?

The command provided in the instructions results in:

helm install chaos-mesh helm/chaos-mesh --namespace=chaos-testing --set chaosDaemon.runtime=containerd --set chaosDaemon.socketPath=/run/containerd/containerd.sock

Error: failed to download "helm/chaos-mesh" (hint: running `helm repo update` may help)

What is changed and how does it work?

Changing it to:

helm install chaos-mesh chaos-mesh/chaos-mesh --namespace=chaos-testing --set chaosDaemon.runtime=containerd --set chaosDaemon.socketPath=/run/containerd/containerd.sock

NAME: chaos-mesh
LAST DEPLOYED: Fri Oct 16 09:51:37 2020
NAMESPACE: chaos-testing
STATUS: deployed
REVISION: 1
TEST SUITE: None
NOTES:
1. Make sure chaos-mesh components are running
   kubectl get pods --namespace chaos-testing -l app.kubernetes.io/instance=chaos-mesh

Solves the issue.

Checklist

Tests

  • Unit test
  • E2E test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Breaking backward compatibility

Related changes

  • Need to update the documentation

Does this PR introduce a user-facing change?

NONE

@cwen0
Copy link
Member

cwen0 commented Oct 16, 2020

@wstrm Thanks for your contribution!

cwen0
cwen0 previously approved these changes Oct 16, 2020
@cwen0 cwen0 added website documentation Improvements or additions to documentation labels Oct 16, 2020
@zhouqiang-cl
Copy link
Contributor

Do we also need to update master/v0.9.1's document? @cwen0

@cwen0
Copy link
Member

cwen0 commented Oct 16, 2020

@zhouqiang-cl Yes, we need to do it, @wstrm Can you help us to update it?

@wstrm
Copy link
Contributor Author

wstrm commented Oct 16, 2020

@wstrm Can you help us to update it?

Ah, yes I'll fix that. 👍

@wstrm
Copy link
Contributor Author

wstrm commented Oct 16, 2020

Done, ready for review again. :)

fewdan
fewdan previously approved these changes Oct 16, 2020
Copy link
Member

@fewdan fewdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cwen0
Copy link
Member

cwen0 commented Oct 16, 2020

@wstrm Can you help to update this file https://github.com/chaos-mesh/chaos-mesh/blob/master/website/docs/get_started/installation.md#step-3-install-chaos-mesh? Thanks! 😏

The command provided in the instructions results in:

$ helm install chaos-mesh helm/chaos-mesh --namespace=chaos-testing --set chaosDaemon.runtime=containerd --set chaosDaemon.socketPath=/run/containerd/containerd.sock
> Error: failed to download "helm/chaos-mesh" (hint: running `helm repo update` may help)

Changing the repository to chaos-mesh solves the issue.

Signed-off-by: William Wennerström <william@wstrm.dev>
Copy link
Member

@cwen0 cwen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhouqiang-cl
Copy link
Contributor

LGTM

Copy link
Contributor

@zhouqiang-cl zhouqiang-cl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhouqiang-cl zhouqiang-cl merged commit 1ecc3bc into chaos-mesh:master Oct 16, 2020
Yiyiyimu pushed a commit to Yiyiyimu/chaos-mesh that referenced this pull request Oct 20, 2020
The command provided in the instructions results in:

$ helm install chaos-mesh helm/chaos-mesh --namespace=chaos-testing --set chaosDaemon.runtime=containerd --set chaosDaemon.socketPath=/run/containerd/containerd.sock
> Error: failed to download "helm/chaos-mesh" (hint: running `helm repo update` may help)

Changing the repository to chaos-mesh solves the issue.

Signed-off-by: William Wennerström <william@wstrm.dev>

Co-authored-by: zhouqiang <zhouqiang.cl@gmail.com>
sjwsl pushed a commit to sjwsl/chaos-mesh that referenced this pull request May 6, 2021
The command provided in the instructions results in:

$ helm install chaos-mesh helm/chaos-mesh --namespace=chaos-testing --set chaosDaemon.runtime=containerd --set chaosDaemon.socketPath=/run/containerd/containerd.sock
> Error: failed to download "helm/chaos-mesh" (hint: running `helm repo update` may help)

Changing the repository to chaos-mesh solves the issue.

Signed-off-by: William Wennerström <william@wstrm.dev>

Co-authored-by: zhouqiang <zhouqiang.cl@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation first-time-contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants