chore: remove duplicate 'GenerateNPods' #1252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yiyiyimu <wosoyoung@gmail.com>
15 tasks
Codecov Report
@@ Coverage Diff @@
## master #1252 +/- ##
==========================================
- Coverage 55.78% 55.09% -0.69%
==========================================
Files 68 81 +13
Lines 4383 4993 +610
==========================================
+ Hits 2445 2751 +306
- Misses 1768 1981 +213
- Partials 170 261 +91
Continue to review full report at Codecov.
|
STRRL
requested changes
Dec 7, 2020
There was a problem hiding this comment.
rest LGTM.
Since we are build test cases, explicitly environment is very important, so using default values is not so good for the situation.
And suggestions for default value: do not apply default value as if value == "" { value = defaultValue }; using a constructor to setup default value;
Signed-off-by: yiyiyimu <wosoyoung@gmail.com>
Signed-off-by: yiyiyimu <wosoyoung@gmail.com>
Signed-off-by: yiyiyimu <wosoyoung@gmail.com>
STRRL
reviewed
Dec 8, 2020
Signed-off-by: yiyiyimu <wosoyoung@gmail.com>
fewdan
previously requested changes
Dec 8, 2020
pkg/utils/generate.go
Outdated
| @@ -0,0 +1,111 @@ | |||
| // Copyright 2019 Chaos Mesh Authors. | |||
Signed-off-by: yiyiyimu <wosoyoung@gmail.com>
Yiyiyimu
force-pushed
the
rm-dup-testutil
branch
from
85c259c
to
e379ad6
Compare
|
/merge |
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
|
/merge |
|
/run-all-tests |
STRRL
pushed a commit
to STRRL/chaos-mesh
that referenced
this pull request
Dec 15, 2020
Signed-off-by: STRRL <str_ruiling@outlook.com>
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: yiyiyimu wosoyoung@gmail.com
What problem does this PR solve?
There are two
GenerateNPodsexists with little difference, so merge them togetherchaos-mesh/pkg/utils/selector_test.go
Line 592 in 26fe552
chaos-mesh/controllers/test/types.go
Line 128 in 6afb841
What is changed and how does it work?
Add a struct so don't need to type in the arguments not used in certain test.
Checklist
Tests
Side effects
Related changes
Does this PR introduce a user-facing change?