Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: chaosctl for print debug info (#1074) #1302

Merged
merged 2 commits into from Dec 18, 2020

Conversation

Yiyiyimu
Copy link
Member

cherry-pick #1074 to release-1.0


Signed-off-by: yiyiyimu wosoyoung@gmail.com

What's this PR did

fix #694

Checklist

SUPPORT CHAOS

  • NetworkChaos
  • StressChaos
  • IoChaos

DEBUG

  • compare with expected (a demo for networkChaos)
  • move to ctrl.client from shell
  • chaos applied on multiple pods (larger radius): use utils.selectPods
  • replace extractFromJson with type assert (as how controllers do)
  • create daemon client locally to get pid more robustly
  • add test case
  • add backup for pod that not has ls, ps and cat
  • add feature to print log from all chaos-mesh components as chaosctl logs

CTL

  • add color to output title
  • use format "chaosctl debug xxxchaos"
  • support chaos in certain namespace
  • use kubectl compatible auto-completion as chaosctl debug xxxchaos CHAOSNAME -n NAMESPACE

Signed-off-by: yiyiyimu <wosoyoung@gmail.com>
Signed-off-by: yiyiyimu <wosoyoung@gmail.com>
@Yiyiyimu
Copy link
Member Author

Since #1074 use the result of #1252, without cherry-pick the later one I directly move the test functions it needs to pkg/utils/generate.go, to make the test work

@STRRL
Copy link
Member

STRRL commented Dec 18, 2020

/run-e2e-tests

Copy link
Member

@STRRL STRRL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@STRRL STRRL requested a review from YangKeao December 18, 2020 09:27
@YangKeao YangKeao merged commit fec5346 into chaos-mesh:release-1.0 Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants