Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNSChaos: add patterns for match domain name #1454

Merged
merged 12 commits into from
Feb 20, 2021

Conversation

WangXiangUSTC
Copy link
Contributor

@WangXiangUSTC WangXiangUSTC commented Jan 26, 2021

What problem does this PR solve?

It's hard to judge a domain name is in the K8s cluster or not.

For example, the content in the /etc/resolv.conf in the Pod is:

search busybox.svc.cluster.local svc.cluster.local cluster.local
nameserver 10.101.127.9
options ndots:5

When ping baidu.com in the Pod, will send requests to DNS Server with domain name baidu.com, busybox.svc.cluster.local, baidu.com.svc.cluster.local, baidu.com.cluster.local.

What is changed and how does it work?

Add new config patterns to match domain name, choose which domain names to take effect, support the placeholder ? and wildcard *, or the Specified domain name.

Checklist

Tests

  • Unit test
  • E2E test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Breaking backward compatibility

Related changes

  • Need to update the documentation

Does this PR introduce a user-facing change?

NONE

Signed-off-by: xiang <xiang13225080@163.com>
Signed-off-by: xiang <xiang13225080@163.com>
Signed-off-by: xiang <xiang13225080@163.com>
Signed-off-by: xiang <xiang13225080@163.com>
Signed-off-by: xiang <xiang13225080@163.com>
@WangXiangUSTC
Copy link
Contributor Author

/run-e2e-tests

1 similar comment
@WangXiangUSTC
Copy link
Contributor Author

/run-e2e-tests

Signed-off-by: xiang <xiang13225080@163.com>
Signed-off-by: xiang <xiang13225080@163.com>
@WangXiangUSTC
Copy link
Contributor Author

/run-e2e-tests

@codecov-io
Copy link

codecov-io commented Jan 27, 2021

Codecov Report

Merging #1454 (2ae53df) into master (7e9ff3f) will decrease coverage by 3.71%.
The diff coverage is 59.38%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1454      +/-   ##
==========================================
- Coverage   55.78%   52.06%   -3.72%     
==========================================
  Files          68       80      +12     
  Lines        4383     5109     +726     
==========================================
+ Hits         2445     2660     +215     
- Misses       1768     2180     +412     
- Partials      170      269      +99     
Impacted Files Coverage Δ
api/v1alpha1/common_types.go 0.00% <0.00%> (ø)
api/v1alpha1/common_webhook.go 100.00% <ø> (ø)
api/v1alpha1/dnschaos_type.go 0.00% <0.00%> (ø)
api/v1alpha1/dnschaos_webhook.go 0.00% <0.00%> (ø)
api/v1alpha1/httpchaos_types.go 0.00% <0.00%> (ø)
api/v1alpha1/iochaos_types.go 0.00% <ø> (-40.00%) ⬇️
api/v1alpha1/jvmchaos_webhook.go 0.00% <0.00%> (ø)
api/v1alpha1/kernelchaos_types.go 0.00% <ø> (-20.00%) ⬇️
api/v1alpha1/kernelchaos_webhook.go 100.00% <ø> (+14.81%) ⬆️
api/v1alpha1/kinds.go 27.27% <ø> (+0.60%) ⬆️
... and 131 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48b1bdd...2ae53df. Read the comment docs.

Signed-off-by: xiang <xiang13225080@163.com>
@WangXiangUSTC WangXiangUSTC changed the title [WIP] DNSChaos: add patterns for match domain name DNSChaos: add patterns for match domain name Jan 27, 2021
Signed-off-by: xiang <xiang13225080@163.com>
@WangXiangUSTC
Copy link
Contributor Author

/run-e2e-tests

Signed-off-by: xiang <xiang13225080@163.com>
Signed-off-by: xiang <xiang13225080@163.com>
Copy link
Member

@cwen0 cwen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WangXiangUSTC
Copy link
Contributor Author

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 08a32ae into chaos-mesh:master Feb 20, 2021
@WangXiangUSTC WangXiangUSTC deleted the xiang/dns_refine branch February 20, 2021 09:13
@g1eny0ung g1eny0ung mentioned this pull request Feb 23, 2021
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants