-
Notifications
You must be signed in to change notification settings - Fork 803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DNSChaos: add patterns for match domain name #1454
Conversation
Signed-off-by: xiang <xiang13225080@163.com>
Signed-off-by: xiang <xiang13225080@163.com>
/run-e2e-tests |
1 similar comment
/run-e2e-tests |
Signed-off-by: xiang <xiang13225080@163.com>
Signed-off-by: xiang <xiang13225080@163.com>
/run-e2e-tests |
Codecov Report
@@ Coverage Diff @@
## master #1454 +/- ##
==========================================
- Coverage 55.78% 52.06% -3.72%
==========================================
Files 68 80 +12
Lines 4383 5109 +726
==========================================
+ Hits 2445 2660 +215
- Misses 1768 2180 +412
- Partials 170 269 +99
Continue to review full report at Codecov.
|
Signed-off-by: xiang <xiang13225080@163.com>
/run-e2e-tests |
Signed-off-by: xiang <xiang13225080@163.com>
Signed-off-by: xiang <xiang13225080@163.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
/run-all-tests |
What problem does this PR solve?
It's hard to judge a domain name is in the K8s cluster or not.
For example, the content in the /etc/resolv.conf in the Pod is:
When ping
baidu.com
in the Pod, will send requests to DNS Server with domain namebaidu.com
,busybox.svc.cluster.local
,baidu.com.svc.cluster.local
,baidu.com.cluster.local
.What is changed and how does it work?
Add new config
patterns
to match domain name, choose which domain names to take effect, support the placeholder ? and wildcard *, or the Specified domain name.Checklist
Tests
Side effects
Related changes
Does this PR introduce a user-facing change?