-
Notifications
You must be signed in to change notification settings - Fork 803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: support dns patterns in UI #1510
Conversation
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #1510 +/- ##
==========================================
- Coverage 55.78% 52.02% -3.76%
==========================================
Files 68 80 +12
Lines 4383 5109 +726
==========================================
+ Hits 2445 2658 +213
- Misses 1768 2181 +413
- Partials 170 270 +100
Continue to review full report at Codecov.
|
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
/run-all-tests |
@g1eny0ung merge failed. |
/run-all-tests |
/run-all-tests |
Signed-off-by: Yue Yang g1enyy0ung@gmail.com
What is changed and how does it work?
As the title.
Previous: #1454.
Checklist
Tests
Side effects
Related changes
Does this PR introduce a user-facing change?