Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: support dns patterns in UI #1510

Merged
merged 5 commits into from
Feb 24, 2021

Conversation

g1eny0ung
Copy link
Member

@g1eny0ung g1eny0ung commented Feb 23, 2021

Signed-off-by: Yue Yang g1enyy0ung@gmail.com

What is changed and how does it work?

As the title.

Previous: #1454.

Checklist

Tests

  • Unit test
  • E2E test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Breaking backward compatibility

Related changes

  • Need to update the documentation

Does this PR introduce a user-facing change?

NONE

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
@codecov-io
Copy link

codecov-io commented Feb 23, 2021

Codecov Report

Merging #1510 (6627e20) into master (7e9ff3f) will decrease coverage by 3.75%.
The diff coverage is 59.38%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1510      +/-   ##
==========================================
- Coverage   55.78%   52.02%   -3.76%     
==========================================
  Files          68       80      +12     
  Lines        4383     5109     +726     
==========================================
+ Hits         2445     2658     +213     
- Misses       1768     2181     +413     
- Partials      170      270     +100     
Impacted Files Coverage Δ
api/v1alpha1/common_types.go 0.00% <0.00%> (ø)
api/v1alpha1/common_webhook.go 100.00% <ø> (ø)
api/v1alpha1/dnschaos_type.go 0.00% <0.00%> (ø)
api/v1alpha1/dnschaos_webhook.go 0.00% <0.00%> (ø)
api/v1alpha1/httpchaos_types.go 0.00% <0.00%> (ø)
api/v1alpha1/iochaos_types.go 0.00% <ø> (-40.00%) ⬇️
api/v1alpha1/jvmchaos_webhook.go 0.00% <0.00%> (ø)
api/v1alpha1/kernelchaos_types.go 0.00% <ø> (-20.00%) ⬇️
api/v1alpha1/kernelchaos_webhook.go 100.00% <ø> (+14.81%) ⬆️
api/v1alpha1/kinds.go 27.27% <ø> (+0.60%) ⬆️
... and 131 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3529bc0...6627e20. Read the comment docs.

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Copy link
Contributor

@WangXiangUSTC WangXiangUSTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@fewdan fewdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fewdan
Copy link
Member

fewdan commented Feb 24, 2021

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@g1eny0ung merge failed.

@g1eny0ung
Copy link
Member Author

/run-all-tests

@g1eny0ung
Copy link
Member Author

/run-all-tests

@g1eny0ung g1eny0ung merged commit 8ac8067 into chaos-mesh:master Feb 24, 2021
@g1eny0ung g1eny0ung deleted the chore/ui-dns-patterns branch February 24, 2021 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants