Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unified selector and new controller design #1578

Merged
merged 31 commits into from
Apr 14, 2021
Merged

Unified selector and new controller design #1578

merged 31 commits into from
Apr 14, 2021

Conversation

YangKeao
Copy link
Member

@YangKeao YangKeao commented Mar 18, 2021 •
edited

Please notice: this PR doesn't merge into master, but a nirvana branch to land the #1520 in 2.0 .

What problem does this PR solve?

This is the first step of #1520 . And the corresponding RFC is at chaos-mesh/rfcs#15

You can feel the fascination of current implementation in the implementation of podkill. It doesn't need to select and the logic is really simple now.

Review Guide

TODO

  • Fix dashboard event (as the StartTime and EndTime have been removed, the events in chaos-dashboard should be modified)
  • Migrate from containerName to containerNames, especially for chaos-dashboard
  • Send Kubernetes events to store the error message
  • Use uber-go/fx to do dependency injection
  • Add GCPChaos, HTTPChaos, KernelChaos, JVMChaos.
  • Condition based status display.

@YangKeao
remove scheduler and abstract selector
db6cb1b 
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
@YangKeao
generate new yaml files
acb7b34 
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
@YangKeao
try to modify status
73a39fd 
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
@YangKeao
try to build new router
3310cda 
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
@YangKeao
move selector place
2c82a59 
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
@YangKeao
define unified selector
3179914 
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
@YangKeao
spec rename
bdd584d 
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
@YangKeao
enable simple chaos
9accec0 
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
@YangKeao
add delete, pause and duration controller
c07127f 
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
@YangKeao
add README.md
a55dc76 
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
@YangKeao
network chaos work well
b2b8d36 
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
@AsterNighT AsterNighT mentioned this pull request Mar 25, 2021
Closed
@YangKeao
TimeChaos works well
3afb14c 
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
@YangKeao
format and make check
084bcc2 
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
@YangKeao
refractor IOChaos
5957523 
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
@YangKeao
pass containerkill and podkill status
a2388ef 
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
@YangKeao
fix dnschaos
6b3ee28 
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
@YangKeao
run make check
f9991f4 
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
@YangKeao
reimpl stresschaos
6028d3b 
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
@YangKeao YangKeao mentioned this pull request Mar 29, 2021
Merged
@YangKeao
add e2e test for stress
505e4c8 
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
@YangKeao
change name to cpuTime
f4fc76c 
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
@YangKeao
format codes
08eac41 
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
@YangKeao
Revert "Use bigheap to inject heap stress (chaos-mesh#776)"
e80e819 
This reverts commit c0ff1bf.

Signed-off-by: Yang Keao <keao.yang@yahoo.com>
@YangKeao
fix e2e test
e90eb9c 
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
@YangKeao
pass stress chaos test
6d107cd 
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
@AsterNighT AsterNighT mentioned this pull request Mar 30, 2021
Closed
@YangKeao
fix AWS test
22d7139 
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
@YangKeao YangKeao mentioned this pull request Apr 1, 2021
Closed
@YangKeao YangKeao requested a review from fewdan April 1, 2021 09:02
@YangKeao YangKeao mentioned this pull request Apr 1, 2021
Open
YangKeao and others added 3 commits April 6, 2021 15:21
@YangKeao
add e2e test for stress (chaos-mesh#1612)
03ae18b 
* add e2e test for stress

Signed-off-by: Yang Keao <keao.yang@yahoo.com>

* change name to cpuTime

Signed-off-by: Yang Keao <keao.yang@yahoo.com>

* format codes

Signed-off-by: Yang Keao <keao.yang@yahoo.com>

* add comment and refine threshold choice

Signed-off-by: Yang Keao <keao.yang@yahoo.com>

* format codes

Signed-off-by: Yang Keao <keao.yang@yahoo.com>

Co-authored-by: Ti Chi Robot <71242396+ti-chi-bot@users.noreply.github.com>
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
@YangKeao
remove jvmchaos kernelchaos httpchaos
5a32a72 
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
@YangKeao
fix dashboard compile error
553ddc4 
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
@YangKeao
use fx to do dependency injection
dab15e7 
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
@YangKeao
add kubernetes events
945a31f 
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
@YangKeao
delegate multiple action chaos
c3118d7 
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
@YangKeao YangKeao marked this pull request as ready for review April 14, 2021 05:30
@YangKeao
Copy link
Member Author

This PR would merge to nirvana branch first, so that other developers could develop new features on this patch.

@YangKeao YangKeao merged commit 9ac5fa8 into chaos-mesh:nirvana Apr 14, 2021
@YangKeao YangKeao mentioned this pull request May 31, 2021
Merged
@hanlins hanlins mentioned this pull request Jul 18, 2023
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fewdan fewdan Awaiting requested review from fewdan

Assignees
No one assigned
Labels
size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@YangKeao @ti-chi-bot