Unified selector #15
Unified selector #15
Conversation
| The controller would construct the `Selector` first, and then use the `Selector` | ||
| to select the chaos targets. However, as the target may have multiple type (it | ||
| could be a pod, a container, a volume or an AWS machine), we can only return an | ||
| `interface{}`, and the implementation of chaos would assert the type by |
There was a problem hiding this comment.
So the controller does not actually know the type of the target? I wonder how it leads to
the controller framework should know the concrete status of every selected targets
Maybe not a interface{}, but some interface Target{}?
There was a problem hiding this comment.
Oops. It needs to know whether these targets are injected or not (or fault), which can be judged according to the return value of Apply/Recover. (If Recover success, then it must have been in "not injected" status 😸 )
There was a problem hiding this comment.
So the granularity of success/failure would be at a per-chaos level. What if some of the targets succeeded but the other failed?
There was a problem hiding this comment.
Nop. In controller, the "success"/"failure" will be per-"target" level, so that the error handling (like "retry") would be simpler.
However, to avoid modifying dashboard, I don't want to modify the specification too rudely. So the per-chaos level will be keeped as the "AND" of every target status, and will only be used to show in dashboard.
There was a problem hiding this comment.
I don't quite get it. How can you get a pre-target status if you do not even know what the target is? (Since it is interface{})
There was a problem hiding this comment.
The "status" is only about whether this chaos has been executed successfully, which we can get from the following return value of Apply or Recover function. Why should I know what the target is?
But yes. I have realized that interface{} is not enough. It has to provide an ID to record the status/running result.
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
It's the very first step of chaos-mesh/chaos-mesh#1520
Please comment if you have better idea :)
@STRRL @Hexilee