Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auth: add rooturl configuration in gcp authentication #2554

Merged
merged 5 commits into from
Nov 24, 2021

Conversation

YangKeao
Copy link
Member

@YangKeao YangKeao commented Nov 23, 2021

Signed-off-by: YangKeao yangkeao@chunibyo.icu

What problem does this PR solve?

Try to get the scheme and host from the request is not realistic. If the dashboard is deployed behind a load balancer, it will have no way to guess the scheme. In this PR, I added a config field, so that the users can set the root url manually. The dashboard will append /api/auth/gcp/callback to the path.

BTW, it also installs the ca-certificates to the chaos-dashboard container, which is required to avoid x509 error.

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 23, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • STRRL
  • g1eny0ung

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
@ti-chi-bot ti-chi-bot added size/M and removed size/S labels Nov 23, 2021
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
@YangKeao YangKeao requested a review from cwen0 November 23, 2021 09:51
@STRRL STRRL added this to the Release 2.1 milestone Nov 24, 2021
Copy link
Member

@STRRL STRRL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! It works!

Copy link
Member

@g1eny0ung g1eny0ung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🍺

@g1eny0ung
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 135f2b7

@cwen0
Copy link
Member

cwen0 commented Nov 24, 2021

/run-e2e-tests

@YangKeao
Copy link
Member Author

/merge

@STRRL
Copy link
Member

STRRL commented Nov 24, 2021

/run-e2e-tests

@ti-chi-bot
Copy link
Member

@YangKeao: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@YangKeao
Copy link
Member Author

/run-e2e-tests

@ti-chi-bot ti-chi-bot merged commit 87a9ee1 into chaos-mesh:master Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants