Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

helm: fix ingress condition #2604

Merged
merged 1 commit into from
Dec 7, 2021
Merged

helm: fix ingress condition #2604

merged 1 commit into from
Dec 7, 2021

Conversation

yehiyam
Copy link
Contributor

@yehiyam yehiyam commented Dec 6, 2021

What problem does this PR solve?

Close #2603

What's changed and how it works?

Fixed condition in helm template that caused the apiVersion to be commented out

Checklist

Tests

  • Unit test
  • E2E test
  • No code
  • Manual test (add steps below)

render chart with helm template to validate that the apiVersion is not commented

Side effects

  • Breaking backward compatibility

Release note 

Fixed helm chart ingress apiVersion missing

DCO

If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it:

git commit --amend --signoff
git push --force

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 6, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Gallardot
  • cwen0

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Member

Welcome @yehiyam!

It looks like this is your first PR to chaos-mesh/chaos-mesh 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to chaos-mesh/chaos-mesh. 😃

@yehiyam
fix ingress condition
7f7b83f 
Signed-off-by: Yehiyam Livneh <yehiyam@gmail.com>
@yehiyam
Copy link
Contributor Author

yehiyam commented Dec 6, 2021

/cc @AsterNighT @Gallardot

Gallardot
Gallardot approved these changes Dec 7, 2021
View reviewed changes
Copy link
Member

@Gallardot Gallardot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @yehiyam , thanks for your contribution!

LGTM!

cwen0
cwen0 approved these changes Dec 7, 2021
View reviewed changes
Copy link
Member

@cwen0 cwen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cwen0
Copy link
Member

cwen0 commented Dec 7, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 7f7b83f

@ti-chi-bot ti-chi-bot merged commit 69c06ca into chaos-mesh:master Dec 7, 2021
@ti-srebot ti-srebot mentioned this pull request Dec 7, 2021
Merged
5 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-2.1 in PR #2605

ti-chi-bot pushed a commit that referenced this pull request Dec 7, 2021
@ti-srebot @yehiyam
helm: fix ingress condition (#2604) (#2605)
e23be3a 
Signed-off-by: Yehiyam Livneh <yehiyam@gmail.com>

Co-authored-by: yehiyam <yehiyam@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gallardot Gallardot Gallardot approved these changes

@cwen0 cwen0 cwen0 approved these changes

@AsterNighT AsterNighT Awaiting requested review from AsterNighT

Assignees
No one assigned
Labels
contribution first-time-contributor needs-cherry-pick-release-2.1 size/XS status/can-merge status/LGT2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

helm install ingress issue
6 participants
@yehiyam @ti-chi-bot @cwen0 @ti-srebot @Gallardot @STRRL