-
Notifications
You must be signed in to change notification settings - Fork 822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
retry oneshot chaos after 1 second if it's not selected #2618
retry oneshot chaos after 1 second if it's not selected #2618
Conversation
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
This pull request has been accepted and is ready to merge. Commit hash: d221a2f
|
cherry pick to release-2.0 in PR #2656 |
cherry pick to release-2.1 in PR #2657 |
Signed-off-by: YangKeao yangkeao@chunibyo.icu
Fix #2607
What problem does this PR solve?
This PR modified the
IsFinished
function. Before this PR, the controller cannot handle the situation where thePodChaos
hasn't selected any pods, (when theschedule-gc
controllers run much faster than therecord
controller)What's changed and how it works?
Related changes
chaos-mesh/website
Dashboard UI