Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

retry oneshot chaos after 1 second if it's not selected #2618

Merged
merged 2 commits into from
Dec 16, 2021
Merged

retry oneshot chaos after 1 second if it's not selected #2618

merged 2 commits into from
Dec 16, 2021

Conversation

YangKeao
Copy link
Member

@YangKeao YangKeao commented Dec 8, 2021 •
edited
Loading

Signed-off-by: YangKeao yangkeao@chunibyo.icu

Fix #2607

What problem does this PR solve?

This PR modified the IsFinished function. Before this PR, the controller cannot handle the situation where the PodChaos hasn't selected any pods, (when the schedule-gc controllers run much faster than the record controller)

What's changed and how it works?

Related changes

  • Need to update chaos-mesh/website
  • Need to update Dashboard UI
  • Need to cheery-pick to release branches
    • release-2.1
    • release-2.0

@YangKeao
retry oneshot chaos after 1 second
29df2de 
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 8, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • STRRL
  • cwen0

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@YangKeao YangKeao changed the title retry oneshot chaos after 1 second retry oneshot chaos after 1 second if it's not selected Dec 8, 2021
STRRL
STRRL approved these changes Dec 16, 2021
View reviewed changes
Copy link
Member

@STRRL STRRL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cwen0
cwen0 approved these changes Dec 16, 2021
View reviewed changes
Copy link
Member

@cwen0 cwen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cwen0
Copy link
Member

cwen0 commented Dec 16, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: d221a2f

@ti-chi-bot ti-chi-bot merged commit 533a86c into chaos-mesh:master Dec 16, 2021
@ti-srebot ti-srebot mentioned this pull request Dec 16, 2021
Merged
4 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-2.0 in PR #2656

@ti-srebot ti-srebot mentioned this pull request Dec 16, 2021
Merged
4 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-2.1 in PR #2657

ti-chi-bot pushed a commit that referenced this pull request Dec 16, 2021
@ti-srebot @YangKeao
retry oneshot chaos after 1 second if it's not selected (#2618) (#2657)
9027d07 
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>

Co-authored-by: YangKeao <yangkeao@chunibyo.icu>
ti-chi-bot pushed a commit that referenced this pull request Dec 16, 2021
@ti-srebot @YangKeao
retry oneshot chaos after 1 second if it's not selected (#2618) (#2656)
c837d72 
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>

Co-authored-by: YangKeao <yangkeao@chunibyo.icu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@STRRL STRRL STRRL approved these changes

@cwen0 cwen0 cwen0 approved these changes

@Colstuwjx Colstuwjx Awaiting requested review from Colstuwjx

Assignees
No one assigned
Labels
needs-cherry-pick-release-2.0 needs-cherry-pick-release-2.1 size/S status/can-merge status/LGT2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Schedule with default value of historyLimit is not working as expected
5 participants
@YangKeao @ti-chi-bot @cwen0 @ti-srebot @STRRL