Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e: Download build cache from file server (#2703) #2718

Merged
merged 2 commits into from
Dec 27, 2021
Merged

e2e: Download build cache from file server (#2703) #2718

merged 2 commits into from
Dec 27, 2021

Conversation

YangKeao
Copy link
Member

No description provided.

@YangKeao
e2e: Download build cache from file server (chaos-mesh#2617, chaos-me…
1729946 
…sh#2702) (chaos-mesh#2703)

* Download build cache from file server (chaos-mesh#2617)

* modify the order of generating files

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>

* download build cache from fileserver

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>

* use master but not build branch

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>

* use Makefile from master

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>

* fix the url of fileserver

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>

* don't unzip the redundant cache

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>

* update master to $\{ghprbTargetBranch\}

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 27, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • STRRL
  • cwen0

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@YangKeao
Copy link
Member Author

/run-e2e-tests

@YangKeao YangKeao requested a review from cwen0 December 27, 2021 06:19
@YangKeao
Copy link
Member Author

/run-e2e-tests

@YangKeao
don't extract redundant cache
1ea9f99 
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
@codecov
Copy link

codecov bot commented Dec 27, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (release-2.0@31f6132). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             release-2.0    #2718   +/-   ##
==============================================
  Coverage               ?   42.78%           
==============================================
  Files                  ?      127           
  Lines                  ?     8862           
  Branches               ?        0           
==============================================
  Hits                   ?     3792           
  Misses                 ?     4744           
  Partials               ?      326

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31f6132...1ea9f99. Read the comment docs.

@YangKeao
Copy link
Member Author

/run-e2e-tests

cwen0
cwen0 approved these changes Dec 27, 2021
View reviewed changes
Copy link
Member

@cwen0 cwen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cwen0
Copy link
Member

cwen0 commented Dec 27, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 1ea9f99

@ti-chi-bot ti-chi-bot merged commit ba7f085 into chaos-mesh:release-2.0 Dec 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@STRRL STRRL STRRL approved these changes

@cwen0 cwen0 cwen0 approved these changes

@g1eny0ung g1eny0ung Awaiting requested review from g1eny0ung

@Hexilee Hexilee Awaiting requested review from Hexilee

@iguoyr iguoyr Awaiting requested review from iguoyr

Assignees
No one assigned
Labels
size/XS status/can-merge status/LGT2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@YangKeao @ti-chi-bot @cwen0 @STRRL