fix: trying to fix real_gettimeofday on arm64 #2849

STRRL · 2022-02-07T12:52:56Z

Signed-off-by: STRRL str_ruiling@outlook.com

What problem does this PR solve?

close #2844

What's changed and how it works?

add parameter tz in real_gettimeofday

Related changes

Need to update chaos-mesh/website
Need to update Dashboard UI
Need to cheery-pick to release branches
- release-2.1
- release-2.0

Checklist

Tests

Unit test
E2E test
No code
Manual test (add steps below)

It could be compiled on my machine.

Side effects

Breaking backward compatibility

Release note

Please add a release note.

You can safely ignore this section if you don't think this PR needs a release note.

DCO

If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it:

git commit --amend --signoff
git push --force

Signed-off-by: STRRL <str_ruiling@outlook.com>

ti-chi-bot · 2022-02-07T12:52:58Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

YangKeao
iguoyr

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

STRRL · 2022-02-07T12:53:09Z

PTAL

/cc @ReigenDing @YangKeao @iguoyr

ti-chi-bot · 2022-02-07T12:53:11Z

@STRRL: GitHub didn't allow me to request PR reviews from the following users: ReigenDing.

Note that only chaos-mesh members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

PTAL

/cc @ReigenDing @YangKeao @iguoyr

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

iguoyr

Rest LGTM

pkg/time/fakeclock/fake_gettimeofday.c

…rm64

Signed-off-by: STRRL <str_ruiling@outlook.com>

YangKeao

LGTM

STRRL · 2022-02-11T05:16:58Z

LGTM

What should I do with compiler warning?

YangKeao · 2022-02-11T06:07:01Z

LGTM

What should I do with compiler warning?

@STRRL As I have tried on my raspberry pi, it can be solved by adding a new register int w0 __asm__("w0"). The result assembly will be really simple:

mov x8, #0xa9
svc #0x0
ret

STRRL · 2022-02-11T06:12:05Z

LGTM

What should I do with compiler warning?

@STRRL As I have tried on my raspberry pi, it can be solved by adding a new register int w0 __asm__("w0"). The result assembly will be really simple:
mov x8, #0xa9
svc #0x0
ret

I do not get the point, it seems it contains many conventions about syscall and assembly that I do not know. 🥲

Could you help me with doing that( by directly pushing codes to this PR)? :P

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>

…rm64 Signed-off-by: YangKeao <yangkeao@chunibyo.icu>

YangKeao · 2022-02-11T07:48:31Z

@STRRL Done.

I'm not sure whether it will actually work, because the ptrace related package doesn't provide an arm implementation, so I cannot verify this implementation through watchmaker.

iguoyr · 2022-02-11T09:31:21Z

@STRRL Done.

I'm not sure whether it will actually work, because the ptrace related package doesn't provide an arm implementation, so I cannot verify this implementation through watchmaker.

Right! Actually we can't execute timechaos experiments on arm64 right now, so in order to fix the CI ASAP, I thought I'd approve it first and fix this feature later.

iguoyr

LGTM

iguoyr · 2022-02-11T09:32:28Z

/merge

ti-chi-bot · 2022-02-11T09:32:30Z

This pull request has been accepted and is ready to merge.

Commit hash: edd1b06

iguoyr · 2022-02-11T10:29:07Z

/run-e2e-tests

ti-srebot · 2022-03-21T13:31:52Z

cherry pick to release-2.1 failed

* fix: trying to fix real_gettimeofday on arm64 Signed-off-by: STRRL <str_ruiling@outlook.com> * chore: remove double underscore with variable tz Signed-off-by: STRRL <str_ruiling@outlook.com> * chore: make linters happy Signed-off-by: STRRL <str_ruiling@outlook.com> * use an extra w0 register Signed-off-by: YangKeao <yangkeao@chunibyo.icu> Co-authored-by: YangKeao <yangkeao@chunibyo.icu>

STRRL · 2022-03-21T13:37:20Z

4d3bfed

It makes no sense, I could manually cherry-pick it with no conflict.

* fix: trying to fix real_gettimeofday on arm64 (#2849) * fix: trying to fix real_gettimeofday on arm64 Signed-off-by: STRRL <str_ruiling@outlook.com> * chore: remove double underscore with variable tz Signed-off-by: STRRL <str_ruiling@outlook.com> * chore: make linters happy Signed-off-by: STRRL <str_ruiling@outlook.com> * use an extra w0 register Signed-off-by: YangKeao <yangkeao@chunibyo.icu> Co-authored-by: YangKeao <yangkeao@chunibyo.icu> * ci: fix `upload-image` action (#2935) * chore: move fake_image to linux_amd64 Signed-off-by: SiyuChen <ryougi201@gmail.com> * chore: fix upload image Signed-off-by: SiyuChen <ryougi201@gmail.com> * fix: remove deafult project env Signed-off-by: SiyuChen <ryougi201@gmail.com> * chore: add FakeImage to fake_image Signed-off-by: SiyuChen <ryougi201@gmail.com> * chore: update e2e image name Signed-off-by: SiyuChen <ryougi201@gmail.com> * chore: fix e2e test Signed-off-by: SiyuChen <ryougi201@gmail.com> * chore: fix e2e test Signed-off-by: SiyuChen <ryougi201@gmail.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io> Co-authored-by: YangKeao <yangkeao@chunibyo.icu> Co-authored-by: Siyu Chen <ryougi201@gmail.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>

* fix: trying to fix real_gettimeofday on arm64 Signed-off-by: STRRL <str_ruiling@outlook.com> * chore: remove double underscore with variable tz Signed-off-by: STRRL <str_ruiling@outlook.com> * chore: make linters happy Signed-off-by: STRRL <str_ruiling@outlook.com> * use an extra w0 register Signed-off-by: YangKeao <yangkeao@chunibyo.icu> Co-authored-by: YangKeao <yangkeao@chunibyo.icu> Signed-off-by: zhqqqy <zhqqqy@163.com>

STRRL added 2 commits February 7, 2022 20:44

fix: trying to fix real_gettimeofday on arm64

7291a38

Signed-off-by: STRRL <str_ruiling@outlook.com>

chore: remove double underscore with variable tz

5944ba9

Signed-off-by: STRRL <str_ruiling@outlook.com>

ti-chi-bot requested a review from Gallardot February 7, 2022 12:53

ti-chi-bot requested a review from YangKeao February 7, 2022 12:53

ti-chi-bot requested a review from iguoyr February 7, 2022 12:53

ti-chi-bot added the size/S label Feb 7, 2022

iguoyr reviewed Feb 8, 2022

View reviewed changes

pkg/time/fakeclock/fake_gettimeofday.c Show resolved Hide resolved

STRRL added 2 commits February 9, 2022 16:00

Merge remote-tracking branch 'upstream/master' into gettimeofdat-on-a…

e7b8cb3

…rm64

chore: make linters happy

e0359d1

Signed-off-by: STRRL <str_ruiling@outlook.com>

iguoyr mentioned this pull request Feb 9, 2022

Github Action: image build action was broken #2865

Closed

ti-chi-bot added the needs-rebase label Feb 9, 2022

YangKeao approved these changes Feb 11, 2022

View reviewed changes

ti-chi-bot added the status/LGT1 label Feb 11, 2022

YangKeao added 2 commits February 11, 2022 07:39

use an extra w0 register

87345c2

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>

Merge remote-tracking branch 'upstream/master' into gettimeofdat-on-a…

edd1b06

…rm64 Signed-off-by: YangKeao <yangkeao@chunibyo.icu>

ti-chi-bot removed the needs-rebase label Feb 11, 2022

iguoyr approved these changes Feb 11, 2022

View reviewed changes

ti-chi-bot added status/LGT2 and removed status/LGT1 labels Feb 11, 2022

ti-chi-bot added the status/can-merge label Feb 11, 2022

ti-chi-bot merged commit 4d3bfed into chaos-mesh:master Feb 11, 2022

STRRL added the needs-cherry-pick-release-2.1 label Mar 21, 2022

STRRL mentioned this pull request Mar 21, 2022

cherrypick #2849 and #2935 into release-2.1 #3049

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: trying to fix real_gettimeofday on arm64 #2849

fix: trying to fix real_gettimeofday on arm64 #2849

STRRL commented Feb 7, 2022

ti-chi-bot commented Feb 7, 2022 •

edited

STRRL commented Feb 7, 2022

ti-chi-bot commented Feb 7, 2022

iguoyr left a comment

YangKeao left a comment

STRRL commented Feb 11, 2022

YangKeao commented Feb 11, 2022 •

edited

STRRL commented Feb 11, 2022

YangKeao commented Feb 11, 2022

iguoyr commented Feb 11, 2022

iguoyr left a comment

iguoyr commented Feb 11, 2022

ti-chi-bot commented Feb 11, 2022

iguoyr commented Feb 11, 2022

ti-srebot commented Mar 21, 2022

STRRL commented Mar 21, 2022

fix: trying to fix real_gettimeofday on arm64 #2849

fix: trying to fix real_gettimeofday on arm64 #2849

Conversation

STRRL commented Feb 7, 2022

What problem does this PR solve?

What's changed and how it works?

Related changes

Checklist

Release note

DCO

ti-chi-bot commented Feb 7, 2022 • edited

STRRL commented Feb 7, 2022

ti-chi-bot commented Feb 7, 2022

iguoyr left a comment

Choose a reason for hiding this comment

YangKeao left a comment

Choose a reason for hiding this comment

STRRL commented Feb 11, 2022

YangKeao commented Feb 11, 2022 • edited

STRRL commented Feb 11, 2022

YangKeao commented Feb 11, 2022

iguoyr commented Feb 11, 2022

iguoyr left a comment

Choose a reason for hiding this comment

iguoyr commented Feb 11, 2022

ti-chi-bot commented Feb 11, 2022

iguoyr commented Feb 11, 2022

ti-srebot commented Mar 21, 2022

STRRL commented Mar 21, 2022

ti-chi-bot commented Feb 7, 2022 •

edited

YangKeao commented Feb 11, 2022 •

edited