ci: fix `upload-image` action #2935

iguoyr · 2022-02-24T06:22:48Z

What problem does this PR solve?

Close #2896

What's changed and how it works?

Related changes

Need to update chaos-mesh/website
Need to update Dashboard UI
Need to cheery-pick to release branches
- release-2.1
- release-2.0

Checklist

Tests

Unit test
E2E test
No code
Manual test (add steps below)

test in my repository: https://github.com/iguoyr/chaos-mesh/runs/5314637511?check_suite_focus=true

Side effects

Breaking backward compatibility

Release note

Please add a release note.

You can safely ignore this section if you don't think this PR needs a release note.

DCO

If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it:

git commit --amend --signoff
git push --force

Signed-off-by: SiyuChen <ryougi201@gmail.com>

ti-chi-bot · 2022-02-24T06:22:49Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

STRRL
YangKeao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

codecov · 2022-02-24T06:34:21Z

Codecov Report

Merging #2935 (d50c5ef) into master (bef9049) will increase coverage by 0.03%.
The diff coverage is 51.56%.

@@            Coverage Diff             @@
##           master    #2935      +/-   ##
==========================================
+ Coverage   40.27%   40.31%   +0.03%     
==========================================
  Files         148      149       +1     
  Lines       12230    12230              
==========================================
+ Hits         4926     4930       +4     
+ Misses       6915     6911       -4     
  Partials      389      389

Impacted Files	Coverage Δ
pkg/time/fake_image.go	`0.00% <ø> (-50.00%)`	⬇️
pkg/time/fake_image_linux_amd64.go	`51.56% <51.56%> (ø)`
pkg/workflow/controllers/deadline_reconciler.go	`69.62% <0.00%> (+2.96%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed0c13e...d50c5ef. Read the comment docs.

YangKeao

LGTM

STRRL

LGTM!

STRRL · 2022-02-24T08:27:33Z

/merge

ti-chi-bot · 2022-02-24T08:27:35Z

This pull request has been accepted and is ready to merge.

Commit hash: 0c762fb

Signed-off-by: SiyuChen <ryougi201@gmail.com>

…-upload-image

iguoyr · 2022-02-24T09:42:32Z

/run-e2e-tests

STRRL · 2022-02-24T10:34:08Z

/merge

ti-chi-bot · 2022-02-24T10:34:11Z

This pull request has been accepted and is ready to merge.

Commit hash: ffdc9a0

STRRL · 2022-02-24T10:42:29Z

e2e failed with error message:

 ERROR: image: "localhost:5000/pingcap/e2e-helper:latest" not present locally

you should also update the hard-coded e2e helper name if you would like to change the IMAGE_PROJECT in makefile.

(How about making these changes in another PR?)

Signed-off-by: SiyuChen <ryougi201@gmail.com>

iguoyr · 2022-02-24T12:49:45Z

e2e failed with error message:
 ERROR: image: "localhost:5000/pingcap/e2e-helper:latest" not present locally
you should also update the hard-coded e2e helper name if you would like to change the IMAGE_PROJECT in makefile.

(How about making these changes in another PR?)

Ok! I have already rollbacked these changes.

iguoyr · 2022-02-24T12:50:10Z

/run-e2e-tests

cwen0 · 2022-02-24T13:46:44Z

/run-e2e-tests

iguoyr · 2022-02-25T03:02:20Z

/run-e2e-tests

STRRL · 2022-02-25T03:35:32Z

/merge

ti-chi-bot · 2022-02-25T03:35:34Z

This pull request has been accepted and is ready to merge.

Commit hash: 6e0cb9d

ti-srebot · 2022-02-25T03:58:27Z

cherry pick to release-2.1 failed

* chore: move fake_image to linux_amd64 Signed-off-by: SiyuChen <ryougi201@gmail.com> * chore: fix upload image Signed-off-by: SiyuChen <ryougi201@gmail.com> * fix: remove deafult project env Signed-off-by: SiyuChen <ryougi201@gmail.com> * chore: add FakeImage to fake_image Signed-off-by: SiyuChen <ryougi201@gmail.com> * chore: update e2e image name Signed-off-by: SiyuChen <ryougi201@gmail.com> * chore: fix e2e test Signed-off-by: SiyuChen <ryougi201@gmail.com> * chore: fix e2e test Signed-off-by: SiyuChen <ryougi201@gmail.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>

* Support cgroup v2 for linux stress experiments Signed-off-by: Igor Cherkaev <igor.cherkaev@copart.com> * Update CHANGELOG.md Signed-off-by: Igor Cherkaev <igor.cherkaev@copart.com> * Trigger verify action when helm chart is modified (#2937) Signed-off-by: SiyuChen <ryougi201@gmail.com> * ci: fix `upload-image` action (#2935) * chore: move fake_image to linux_amd64 Signed-off-by: SiyuChen <ryougi201@gmail.com> * chore: fix upload image Signed-off-by: SiyuChen <ryougi201@gmail.com> * fix: remove deafult project env Signed-off-by: SiyuChen <ryougi201@gmail.com> * chore: add FakeImage to fake_image Signed-off-by: SiyuChen <ryougi201@gmail.com> * chore: update e2e image name Signed-off-by: SiyuChen <ryougi201@gmail.com> * chore: fix e2e test Signed-off-by: SiyuChen <ryougi201@gmail.com> * chore: fix e2e test Signed-off-by: SiyuChen <ryougi201@gmail.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io> * fix(ui): pod phases should be first letter capitalized (#2915) * fix(ui): pod phases should be first letter capitalized Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * fix: unify label case Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io> * feat: OpenAPI to TypeScript API Client and Form Data (#2770) * feat: OpenAPI to TypeScript API Client and Forms Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * fix: license checker Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * fix: go (verify) Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * chore: add comments Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * chore: reuse kubebuilder marks Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * chore: update according to RFC Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * chore: prevent ui:form appearing in crds Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * fix: add missing actions Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * chore: update lockfile Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * chore: support PhysicalMachineChaos Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * chore: merge commands into codegen Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * fix: license checker Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * fix: ci Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * fix: supplement another ignore check Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * chore: update package info Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * chore: update README Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * chore: update Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * chore: gen HTTPChaos Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * chore: update changelog Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * fix: remove nested ignores Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * fix: remove remaining markers Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * fix: typo Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * fix: supplement comments Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io> * fix(workflow): no more event after accomplished (#2911) Signed-off-by: imlonghao <git@imlonghao.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io> * helm: add TTL configuration on value.yaml and update helm docs (#2921) * helm: update archived data's ttl Signed-off-by: cwen0 <cwenyin0@gmail.com> * update helm doc Signed-off-by: cwen0 <cwenyin0@gmail.com> * fix comments Signed-off-by: cwen0 <cwenyin0@gmail.com> * fix comments Signed-off-by: cwen0 <cwenyin0@gmail.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io> * fix wrong comment on workflow Dashboard HTTP API (#2947) * fix wrong comment on workflow Dashboard HTTP API Signed-off-by: xiang <xiang13225080@163.com> * update swagger Signed-off-by: xiang <xiang13225080@163.com> * api: export one module for a group of api (#2824) * move v1alpha1 module to api Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * make check Signed-off-by: YangKeao <yangkeao@chunibyo.icu> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io> * fix: replaced localhost:5000 with ghcr.io as registry name (#2919) * fix: replaced localhost:5000 with ghcr.io as registry name when building images Signed-off-by: Rohan Kumar <rohankmr414@gmail.com> * import fix Signed-off-by: Rohan Kumar <rohankmr414@gmail.com> * import fix Signed-off-by: Rohan Kumar <rohankmr414@gmail.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io> * refactor bpm: generate uid for each process; remove identifier lock; remove blockingBuffer (#2918) * support uuid Signed-off-by: xixi <i@hexilee.me> * chaosdaemon fits new bpm Signed-off-by: xixi <i@hexilee.me> * save chaosdaemon/server Signed-off-by: xixi <i@hexilee.me> * make check Signed-off-by: xixi <i@hexilee.me> * add some comments Signed-off-by: xixi <i@hexilee.me> * fix stress chaos Signed-off-by: xixi <i@hexilee.me> * deprecate stdio lock and blockingbuffer Signed-off-by: xixi <i@hexilee.me> * remove buffers in bpm Signed-off-by: xixi <i@hexilee.me> * make check Signed-off-by: xixi <i@hexilee.me> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io> * log: add customized logger for daemon and bpm (#2902) * add customized logger for daemon and bpm Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * extract the grpc metadata into the context Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * make check Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * make check Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * remove log parameter in killIOChaos Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * add logs Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * remove log parameter in httpchaos server Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * add the context comments for process builder Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * make check Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * use the logger in arguments Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * add back boilerplate Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * fix make check Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * add auto compile github action (#2948) * add auto compile github action Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * modify the name of action Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * remove comment expression Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * add comments validation Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * rename the zst file name Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * auto detect buildenv and devenv Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * fix artifact url Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * add debug information Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * add cache and debug artifact url Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * fix bash script Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * modify cache step name Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * use another docker buildx driver Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * add download bash script Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * add boilerplate Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * add some comments and help message Signed-off-by: YangKeao <yangkeao@chunibyo.icu> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io> * Support cgroup v2 for linux stress experiments Signed-off-by: Igor Cherkaev <igor.cherkaev@copart.com> * Update auto-generated code Signed-off-by: Igor Cherkaev <igor.cherkaev@copart.com> Co-authored-by: Siyu Chen <ryougi201@gmail.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io> Co-authored-by: Yue Yang <g1enyy0ung@gmail.com> Co-authored-by: imlonghao <git@imlonghao.com> Co-authored-by: CWen <cwenyin0@gmail.com> Co-authored-by: WangXiang <xiang13225080@163.com> Co-authored-by: YangKeao <yangkeao@chunibyo.icu> Co-authored-by: Rohan Kumar <rohankmr414@gmail.com> Co-authored-by: xixi <i@hexilee.me>

* chore: move fake_image to linux_amd64 Signed-off-by: SiyuChen <ryougi201@gmail.com> * chore: fix upload image Signed-off-by: SiyuChen <ryougi201@gmail.com> * fix: remove deafult project env Signed-off-by: SiyuChen <ryougi201@gmail.com> * chore: add FakeImage to fake_image Signed-off-by: SiyuChen <ryougi201@gmail.com> * chore: update e2e image name Signed-off-by: SiyuChen <ryougi201@gmail.com> * chore: fix e2e test Signed-off-by: SiyuChen <ryougi201@gmail.com> * chore: fix e2e test Signed-off-by: SiyuChen <ryougi201@gmail.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>

* fix: trying to fix real_gettimeofday on arm64 (#2849) * fix: trying to fix real_gettimeofday on arm64 Signed-off-by: STRRL <str_ruiling@outlook.com> * chore: remove double underscore with variable tz Signed-off-by: STRRL <str_ruiling@outlook.com> * chore: make linters happy Signed-off-by: STRRL <str_ruiling@outlook.com> * use an extra w0 register Signed-off-by: YangKeao <yangkeao@chunibyo.icu> Co-authored-by: YangKeao <yangkeao@chunibyo.icu> * ci: fix `upload-image` action (#2935) * chore: move fake_image to linux_amd64 Signed-off-by: SiyuChen <ryougi201@gmail.com> * chore: fix upload image Signed-off-by: SiyuChen <ryougi201@gmail.com> * fix: remove deafult project env Signed-off-by: SiyuChen <ryougi201@gmail.com> * chore: add FakeImage to fake_image Signed-off-by: SiyuChen <ryougi201@gmail.com> * chore: update e2e image name Signed-off-by: SiyuChen <ryougi201@gmail.com> * chore: fix e2e test Signed-off-by: SiyuChen <ryougi201@gmail.com> * chore: fix e2e test Signed-off-by: SiyuChen <ryougi201@gmail.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io> Co-authored-by: YangKeao <yangkeao@chunibyo.icu> Co-authored-by: Siyu Chen <ryougi201@gmail.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>

* chore: move fake_image to linux_amd64 Signed-off-by: SiyuChen <ryougi201@gmail.com> * chore: fix upload image Signed-off-by: SiyuChen <ryougi201@gmail.com> * fix: remove deafult project env Signed-off-by: SiyuChen <ryougi201@gmail.com> * chore: add FakeImage to fake_image Signed-off-by: SiyuChen <ryougi201@gmail.com> * chore: update e2e image name Signed-off-by: SiyuChen <ryougi201@gmail.com> * chore: fix e2e test Signed-off-by: SiyuChen <ryougi201@gmail.com> * chore: fix e2e test Signed-off-by: SiyuChen <ryougi201@gmail.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io> Signed-off-by: zhqqqy <zhqqqy@163.com>

iguoyr added 4 commits February 14, 2022 10:59

chore: move fake_image to linux_amd64

c55885d

Signed-off-by: SiyuChen <ryougi201@gmail.com>

chore: fix upload image

75ead33

Signed-off-by: SiyuChen <ryougi201@gmail.com>

fix: remove deafult project env

0584ab8

Signed-off-by: SiyuChen <ryougi201@gmail.com>

chore: add FakeImage to fake_image

0c762fb

Signed-off-by: SiyuChen <ryougi201@gmail.com>

iguoyr added the type/bug-fix A bug needs to be fixed. label Feb 24, 2022

ti-chi-bot requested review from STRRL and YangKeao February 24, 2022 06:22

ti-chi-bot added the size/L label Feb 24, 2022

YangKeao approved these changes Feb 24, 2022

View reviewed changes

ti-chi-bot added the status/LGT1 label Feb 24, 2022

STRRL approved these changes Feb 24, 2022

View reviewed changes

ti-chi-bot added status/LGT2 and removed status/LGT1 labels Feb 24, 2022

ti-chi-bot added the status/can-merge label Feb 24, 2022

Merge branch 'master' into fix-ci-upload-image

56d6d5c

STRRL added the needs-cherry-pick-release-2.1 label Feb 24, 2022

iguoyr added 2 commits February 24, 2022 17:40

chore: update e2e image name

dd87a7e

Signed-off-by: SiyuChen <ryougi201@gmail.com>

Merge remote-tracking branch 'origin/fix-ci-upload-image' into fix-ci…

ffdc9a0

…-upload-image

ti-chi-bot removed the status/can-merge label Feb 24, 2022

ti-chi-bot added the status/can-merge label Feb 24, 2022

chore: fix e2e test

e5c6b72

Signed-off-by: SiyuChen <ryougi201@gmail.com>

ti-chi-bot removed the status/can-merge label Feb 24, 2022

chore: fix e2e test

6e0cb9d

Signed-off-by: SiyuChen <ryougi201@gmail.com>

ti-chi-bot added the status/can-merge label Feb 25, 2022

Merge branch 'master' into fix-ci-upload-image

d50c5ef

ti-chi-bot merged commit cf1ca1c into chaos-mesh:master Feb 25, 2022

iguoyr deleted the fix-ci-upload-image branch March 17, 2022 05:54

STRRL mentioned this pull request Mar 21, 2022

cherrypick #2849 and #2935 into release-2.1 #3049

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ci: fix `upload-image` action #2935

ci: fix `upload-image` action #2935

iguoyr commented Feb 24, 2022

ti-chi-bot commented Feb 24, 2022 •

edited

codecov bot commented Feb 24, 2022 •

edited

YangKeao left a comment

STRRL left a comment

STRRL commented Feb 24, 2022

ti-chi-bot commented Feb 24, 2022

iguoyr commented Feb 24, 2022

STRRL commented Feb 24, 2022

ti-chi-bot commented Feb 24, 2022

STRRL commented Feb 24, 2022

iguoyr commented Feb 24, 2022

iguoyr commented Feb 24, 2022

cwen0 commented Feb 24, 2022

iguoyr commented Feb 25, 2022

STRRL commented Feb 25, 2022

ti-chi-bot commented Feb 25, 2022

ti-srebot commented Feb 25, 2022

ci: fix upload-image action #2935

ci: fix upload-image action #2935

Conversation

iguoyr commented Feb 24, 2022

What problem does this PR solve?

What's changed and how it works?

Related changes

Checklist

Release note

DCO

ti-chi-bot commented Feb 24, 2022 • edited

codecov bot commented Feb 24, 2022 • edited

Codecov Report

YangKeao left a comment

Choose a reason for hiding this comment

STRRL left a comment

Choose a reason for hiding this comment

STRRL commented Feb 24, 2022

ti-chi-bot commented Feb 24, 2022

iguoyr commented Feb 24, 2022

STRRL commented Feb 24, 2022

ti-chi-bot commented Feb 24, 2022

STRRL commented Feb 24, 2022

iguoyr commented Feb 24, 2022

iguoyr commented Feb 24, 2022

cwen0 commented Feb 24, 2022

iguoyr commented Feb 25, 2022

STRRL commented Feb 25, 2022

ti-chi-bot commented Feb 25, 2022

ti-srebot commented Feb 25, 2022

ci: fix `upload-image` action #2935

ci: fix `upload-image` action #2935

ti-chi-bot commented Feb 24, 2022 •

edited

codecov bot commented Feb 24, 2022 •

edited