Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JVMChaos: support inject fault into MySQL client #3277

Merged
merged 9 commits into from
Jun 15, 2022

Conversation

WangXiangUSTC
Copy link
Contributor

@WangXiangUSTC WangXiangUSTC commented May 19, 2022

What problem does this PR solve?

close issue #2977

(this pr is cherry-picked from #3189)

What's changed and how it works?

Using sql-helper in byteman-helper to analyze SQLs, and judge whether to inject fault.

Related changes

  • Need to update chaos-mesh/website
  • Need to update Dashboard UI
  • Need to cheery-pick to release branches
    • release-2.2
    • release-2.1

Checklist

CHANGELOG

  • I have updated the CHANGELOG.md
  • I have labeled this PR with "no-need-update-changelog"

Tests

  • Unit test
  • E2E test
  • No code
  • Manual test (add steps below)

Side effects

  • Breaking backward compatibility

Release note

Please add a release note.

You can safely ignore this section if you don't think this PR needs a release note.

DCO

If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it:

git commit --amend --signoff
git push --force

Signed-off-by: xiang <xiang13225080@163.com>
Signed-off-by: xiang <xiang13225080@163.com>
Signed-off-by: xiang <xiang13225080@163.com>
Signed-off-by: xiang <xiang13225080@163.com>
Signed-off-by: xiang <xiang13225080@163.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 19, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • STRRL
  • cwen0

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@codecov
Copy link

codecov bot commented May 19, 2022

Codecov Report

Merging #3277 (97b7de8) into master (61c4c22) will increase coverage by 0.01%.
The diff coverage is 51.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3277      +/-   ##
==========================================
+ Coverage   41.09%   41.11%   +0.01%     
==========================================
  Files         165      165              
  Lines       13819    13853      +34     
==========================================
+ Hits         5679     5695      +16     
- Misses       7712     7725      +13     
- Partials      428      433       +5     
Impacted Files Coverage Δ
api/v1alpha1/jvmchaos_types.go 33.33% <ø> (ø)
api/v1alpha1/jvmchaos_webhook.go 58.62% <0.00%> (-10.77%) ⬇️
controllers/chaosimpl/jvmchaos/impl.go 37.65% <69.23%> (+5.53%) ⬆️
...g/workflow/controllers/parallel_node_reconciler.go 60.12% <0.00%> (-1.90%) ⬇️
pkg/workflow/controllers/serial_node_reconciler.go 59.58% <0.00%> (-1.56%) ⬇️
pkg/workflow/controllers/statuscheck_reconciler.go 7.57% <0.00%> (-1.52%) ⬇️
pkg/workflow/controllers/task_reconciler.go 5.89% <0.00%> (-0.81%) ⬇️
pkg/workflow/controllers/deadline_reconciler.go 69.62% <0.00%> (+5.18%) ⬆️
.../workflow/controllers/abort_workflow_reconciler.go 57.14% <0.00%> (+8.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b896fb...97b7de8. Read the comment docs.

Signed-off-by: xiang <xiang13225080@163.com>
@WangXiangUSTC
Copy link
Contributor Author

@STRRL PTAL again, all comments in #3189 is addressed

Copy link
Member

@STRRL STRRL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM!

api/v1alpha1/jvmchaos_types.go Outdated Show resolved Hide resolved
Signed-off-by: xiang <xiang13225080@163.com>
Copy link
Member

@STRRL STRRL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@cwen0 cwen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cwen0
Copy link
Member

cwen0 commented Jun 15, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 307e7ca

@ti-chi-bot ti-chi-bot merged commit d120d2d into chaos-mesh:master Jun 15, 2022
@ti-srebot
Copy link
Contributor

cherry pick to release-2.2 in PR #3362

stephen-harris pushed a commit to stephen-harris/chaos-mesh that referenced this pull request Jun 23, 2022
* update api

Signed-off-by: xiang <xiang13225080@163.com>

* generate byteman rule file for mysql

Signed-off-by: xiang <xiang13225080@163.com>

* minor fix

Signed-off-by: xiang <xiang13225080@163.com>

* add integration test

Signed-off-by: xiang <xiang13225080@163.com>

* fix ci

Signed-off-by: xiang <xiang13225080@163.com>

* address comment

Signed-off-by: xiang <xiang13225080@163.com>

* update comment

Signed-off-by: xiang <xiang13225080@163.com>

Co-authored-by: Zhou Zhiqiang <im@strrl.dev>
Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Signed-off-by: Stephen Harris <stephen.harris1@kaluza.com>
ti-chi-bot added a commit that referenced this pull request Jun 28, 2022
* update api

Signed-off-by: xiang <xiang13225080@163.com>

* generate byteman rule file for mysql

Signed-off-by: xiang <xiang13225080@163.com>

* minor fix

Signed-off-by: xiang <xiang13225080@163.com>

* add integration test

Signed-off-by: xiang <xiang13225080@163.com>

* fix ci

Signed-off-by: xiang <xiang13225080@163.com>

* address comment

Signed-off-by: xiang <xiang13225080@163.com>

* update comment

Signed-off-by: xiang <xiang13225080@163.com>

* update yaml

Signed-off-by: xiang <xiang13225080@163.com>

* update CHANGELOG

Signed-off-by: xiang <xiang13225080@163.com>

Co-authored-by: xiang <xiang13225080@163.com>
Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
@STRRL STRRL added this to the Release 2.3 milestone Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants