Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multicluster: helm integration to install/upgrade Chaos Mesh in RemoteCluster #3384

Merged
merged 9 commits into from Oct 25, 2022

Conversation

STRRL
Copy link
Member

@STRRL STRRL commented Jun 21, 2022

What problem does this PR solve?

This PR has been rebased on #3342, so it contains a lot of changes.

The basic changes based on #3342 contain:

  • pkg/helm

After #3342 merged, I would rebase this PR to branch master.

It's a part of #3341;

What's changed and how it works?

Related changes

  • Need to update chaos-mesh/website
  • Need to update Dashboard UI
  • Need to cheery-pick to release branches
    • release-2.2
    • release-2.1

Checklist

CHANGELOG

  • I have updated the CHANGELOG.md
  • I have labeled this PR with "no-need-update-changelog"

Tests

  • Unit test
  • E2E test
  • No code
  • Manual test (add steps below)

I tested it manually by

  • running example functions

Side effects

  • Breaking backward compatibility

DCO

If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it:

git commit --amend --signoff
git push --force

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 21, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • cwen0
  • xlgao-zju

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@STRRL
Copy link
Member Author

STRRL commented Jun 27, 2022

/cc @YangKeao @FingerLeader

I think this PR is ready for review. PTAL :)

@YangKeao
Copy link
Member

YangKeao commented Jul 6, 2022

As this PR is merged in #3414, maybe we could close it?

@YangKeao YangKeao changed the title [multicluster] helm integration to install/upgrade Chaos Mesh in RemoteCluster multicluster: helm integration to install/upgrade Chaos Mesh in RemoteCluster Jul 15, 2022
@YangKeao
Copy link
Member

YangKeao commented Aug 4, 2022

#3384 @STRRL could you please update the PR to align with the master?

@cwen0
Copy link
Member

cwen0 commented Sep 5, 2022

#3384 @STRRL could you please update the PR to align with the master?

@STRRL PTAL

@codecov
Copy link

codecov bot commented Sep 5, 2022

Codecov Report

Merging #3384 (f8b2b1d) into master (0bac96e) will decrease coverage by 0.28%.
The diff coverage is 15.78%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3384      +/-   ##
==========================================
- Coverage   40.26%   39.97%   -0.29%     
==========================================
  Files         166      168       +2     
  Lines       14191    14286      +95     
==========================================
- Hits         5714     5711       -3     
- Misses       8045     8132      +87     
- Partials      432      443      +11     
Impacted Files Coverage Δ
pkg/helm/helm_client.go 0.00% <0.00%> (ø)
pkg/helm/chart.go 45.45% <45.45%> (ø)
pkg/workflow/controllers/deadline_reconciler.go 64.44% <0.00%> (-5.19%) ⬇️
...g/workflow/controllers/parallel_node_reconciler.go 60.12% <0.00%> (-1.90%) ⬇️
pkg/workflow/controllers/serial_node_reconciler.go 59.58% <0.00%> (-1.56%) ⬇️
pkg/workflow/controllers/statuscheck_reconciler.go 7.57% <0.00%> (-1.52%) ⬇️
api/v1alpha1/zz_generated.chaosmesh.go 56.27% <0.00%> (-0.31%) ⬇️
pkg/workflow/controllers/utils.go 87.59% <0.00%> (+1.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bac96e...f8b2b1d. Read the comment docs.

@STRRL
Copy link
Member Author

STRRL commented Sep 5, 2022

Updated! I think this PR is ready for review!

/cc @cwen0 @YangKeao

@ti-chi-bot ti-chi-bot requested review from cwen0 and removed request for YangKeao September 5, 2022 13:16
Signed-off-by: STRRL <im@strrl.dev>
Signed-off-by: STRRL <im@strrl.dev>
Signed-off-by: STRRL <im@strrl.dev>
Signed-off-by: STRRL <im@strrl.dev>
Signed-off-by: STRRL <im@strrl.dev>
Signed-off-by: STRRL <im@strrl.dev>
@STRRL
Copy link
Member Author

STRRL commented Oct 6, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 1333c95

@cwen0
Copy link
Member

cwen0 commented Oct 18, 2022

@STRRL Can you fix the conflicts and make this pr mergeable?

@cwen0
Copy link
Member

cwen0 commented Oct 25, 2022

@STRRL Can you fix the conflicts?

@STRRL
Copy link
Member Author

STRRL commented Oct 25, 2022

@STRRL Can you fix the conflicts?

Done

@STRRL
Copy link
Member Author

STRRL commented Oct 25, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 2b93f48

@ti-chi-bot
Copy link
Member

@STRRL: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants