Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multicluster: auto install and uninstall the remote helm release #3414

Merged
merged 30 commits into from
Nov 15, 2022

Conversation

YangKeao
Copy link
Member

@YangKeao YangKeao commented Jun 30, 2022

What problem does this PR solve?

It automatically install and uninstall the helm release in the remote cluster.

What's changed and how it works?

Documentation: chaos-mesh/website#365.

It adds some logic in the reconciler, and modified the helm pkg to use client config in memory.

Tests

  • Unit test
  • E2E test
  • No code
  • Manual test (add steps below)

Setting up two clusters like described in #3329 , and apply the example configuration: kubectl --context=chaos-mesh-01 apply -f examples/remote-cluster.yaml, you will find the chaos mesh is installed in the chaos-mesh namespace of chaos-mesh-02.

The running status management will be handled in the another PR.

@STRRL @FingerLeader We actually have three PRs stacked now:

  1. [multicluster] bootstrap controller manager at runtime with clusterregistry
  2. [multicluster] helm integration to install/upgrade Chaos Mesh in RemoteCluster
  3. This one

We need to decide merge them one by one, or only merge this PR 🤔

YangKeao and others added 13 commits June 8, 2022 11:25
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
…roller-manager

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
Signed-off-by: STRRL <im@strrl.dev>
Signed-off-by: STRRL <im@strrl.dev>
Signed-off-by: STRRL <im@strrl.dev>
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 30, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • cwen0

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
…elm-pkg

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
@YangKeao YangKeao changed the title [multicluster] auto install and uninstall the remote helm release multicluster: auto install and uninstall the remote helm release Jul 15, 2022
Signed-off-by: STRRL <im@strrl.dev>
Signed-off-by: STRRL <im@strrl.dev>
Signed-off-by: STRRL <im@strrl.dev>
Signed-off-by: STRRL <im@strrl.dev>
Signed-off-by: STRRL <im@strrl.dev>
CHANGELOG.md Outdated Show resolved Hide resolved
controllers/multicluster/remotecluster/controller.go Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
controllers/multicluster/remotecluster/controller.go Outdated Show resolved Hide resolved
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
…elm-pkg

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
@YangKeao YangKeao force-pushed the integrate-strrl-helm-pkg branch 2 times, most recently from bb6ef31 to 8fbec0c Compare November 1, 2022 13:11
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
@cwen0 cwen0 self-requested a review November 2, 2022 14:48
Copy link
Member

@cwen0 cwen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cwen0
Copy link
Member

cwen0 commented Nov 2, 2022

@STRRL PTAL

@cwen0
Copy link
Member

cwen0 commented Nov 15, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 3d136b9

@ti-chi-bot
Copy link
Member

@YangKeao: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #3796.

ti-chi-bot added a commit that referenced this pull request Nov 17, 2022
…) (#3796)

* add remotecluster type

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>

* add the infrastructure to operate multiple clusters

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>

* remove clientset

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>

* modify changelog

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>

* add license to the remote-cluster.yaml

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>

* fix Wrapf arguments

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>

* make check

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>

* make the lock private

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>

* chore: helm chart integration and basic interface

Signed-off-by: STRRL <im@strrl.dev>

* chore: complete the implementation of ReleaseService

Signed-off-by: STRRL <im@strrl.dev>

* chore: update changelog

Signed-off-by: STRRL <im@strrl.dev>

* install chaos mesh

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>

* add CHANGELOG

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>

* chore: helm chart integration and basic interface

Signed-off-by: STRRL <im@strrl.dev>

* chore: complete the implementation of ReleaseService

Signed-off-by: STRRL <im@strrl.dev>

* chore: update changelog

Signed-off-by: STRRL <im@strrl.dev>

* chore: fix make check

Signed-off-by: STRRL <im@strrl.dev>

* chore: update lincense checker config file

Signed-off-by: STRRL <im@strrl.dev>

* test: mark examples of helm as integration test

Signed-off-by: STRRL <im@strrl.dev>

* add condition initialization for remote cluster

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>

* upgrade chaosmesh release version to 2.4.1

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
Signed-off-by: STRRL <im@strrl.dev>
Co-authored-by: STRRL <im@strrl.dev>
Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
Signed-off-by: STRRL <im@strrl.dev>
Co-authored-by: YangKeao <yangkeao@chunibyo.icu>
Co-authored-by: STRRL <im@strrl.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants