-
Notifications
You must be signed in to change notification settings - Fork 801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
multicluster: auto install and uninstall the remote helm release #3414
multicluster: auto install and uninstall the remote helm release #3414
Conversation
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
…roller-manager Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
Signed-off-by: STRRL <im@strrl.dev>
Signed-off-by: STRRL <im@strrl.dev>
Signed-off-by: STRRL <im@strrl.dev>
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
…elm-pkg Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
Signed-off-by: STRRL <im@strrl.dev>
Signed-off-by: STRRL <im@strrl.dev>
Signed-off-by: STRRL <im@strrl.dev>
Signed-off-by: STRRL <im@strrl.dev>
Signed-off-by: STRRL <im@strrl.dev>
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
…elm-pkg Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
bb6ef31
to
8fbec0c
Compare
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
8fbec0c
to
3d136b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@STRRL PTAL |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 3d136b9
|
@YangKeao: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
In response to a cherrypick label: new pull request created: #3796. |
…) (#3796) * add remotecluster type Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * add the infrastructure to operate multiple clusters Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * remove clientset Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * modify changelog Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * add license to the remote-cluster.yaml Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * fix Wrapf arguments Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * make check Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * make the lock private Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * chore: helm chart integration and basic interface Signed-off-by: STRRL <im@strrl.dev> * chore: complete the implementation of ReleaseService Signed-off-by: STRRL <im@strrl.dev> * chore: update changelog Signed-off-by: STRRL <im@strrl.dev> * install chaos mesh Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * add CHANGELOG Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * chore: helm chart integration and basic interface Signed-off-by: STRRL <im@strrl.dev> * chore: complete the implementation of ReleaseService Signed-off-by: STRRL <im@strrl.dev> * chore: update changelog Signed-off-by: STRRL <im@strrl.dev> * chore: fix make check Signed-off-by: STRRL <im@strrl.dev> * chore: update lincense checker config file Signed-off-by: STRRL <im@strrl.dev> * test: mark examples of helm as integration test Signed-off-by: STRRL <im@strrl.dev> * add condition initialization for remote cluster Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * upgrade chaosmesh release version to 2.4.1 Signed-off-by: YangKeao <yangkeao@chunibyo.icu> Signed-off-by: YangKeao <yangkeao@chunibyo.icu> Signed-off-by: STRRL <im@strrl.dev> Co-authored-by: STRRL <im@strrl.dev> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io> Signed-off-by: YangKeao <yangkeao@chunibyo.icu> Signed-off-by: STRRL <im@strrl.dev> Co-authored-by: YangKeao <yangkeao@chunibyo.icu> Co-authored-by: STRRL <im@strrl.dev>
What problem does this PR solve?
It automatically install and uninstall the helm release in the remote cluster.
What's changed and how it works?
Documentation: chaos-mesh/website#365.
It adds some logic in the reconciler, and modified the helm pkg to use client config in memory.
Tests
Setting up two clusters like described in #3329 , and apply the example configuration:
kubectl --context=chaos-mesh-01 apply -f examples/remote-cluster.yaml
, you will find the chaos mesh is installed in thechaos-mesh
namespace of chaos-mesh-02.The running status management will be handled in the another PR.
@STRRL @FingerLeader We actually have three PRs stacked now:
We need to decide merge them one by one, or only merge this PR 🤔