Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade dns coredns image url to ghcr.io #3488

Merged
merged 29 commits into from
Mar 10, 2023

Conversation

YangKeao
Copy link
Member

@YangKeao YangKeao commented Jul 26, 2022

Signed-off-by: YangKeao yangkeao@chunibyo.icu

What problem does this PR solve?

DNSChaos supports arm64 now!

What's changed and how it works?

  1. Use the coredns image build on our own CI and published on ghcr.io
  2. Replace tons of pingcap project into chaos-mesh project.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 26, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • STRRL
  • cwen0

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
@codecov
Copy link

codecov bot commented Jul 26, 2022

Codecov Report

Merging #3488 (e34b303) into master (43fa669) will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3488      +/-   ##
==========================================
+ Coverage   38.50%   38.56%   +0.05%     
==========================================
  Files         165      165              
  Lines       13698    13698              
==========================================
+ Hits         5275     5283       +8     
+ Misses       7992     7983       -9     
- Partials      431      432       +1     

see 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43fa669...e34b303. Read the comment docs.

@STRRL STRRL added the no-need-update-changelog Skip CI check "Must Update CHANGELOG" for this PR label Jul 26, 2022
Copy link
Member

@STRRL STRRL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
Copy link
Member

@cwen0 cwen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cwen0
Copy link
Member

cwen0 commented Jul 27, 2022

/merge

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
@cwen0
Copy link
Member

cwen0 commented Jul 28, 2022

/merge

@ti-chi-bot
Copy link
Member

@YangKeao: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@YangKeao
Copy link
Member Author

/hold

This PR cannot pass the CI. I'll fix it later.

@STRRL
Copy link
Member

STRRL commented Jul 28, 2022

/hold

This PR cannot pass the CI. I'll fix it later.

I found

/hold

This PR cannot pass the CI. I'll fix it later.

I found that the ghcr.io/chaos-mesh/chaos-coredns:v0.2.1-r1 might not work well:

I download logs from artifacts: https://github.com/chaos-mesh/chaos-mesh/actions/runs/2751672468

the container is not ready, with status:

  containerStatuses:
  - containerID: docker://ba34fa66001a517c68cb40a05e8074bc283389b0d01b19fa16be1aa9b3de1df0
    image: ghcr.io/chaos-mesh/chaos-coredns:v0.2.1-r1
    imageID: docker-pullable://ghcr.io/chaos-mesh/chaos-coredns@sha256:f4d9e55d9bb11c120d038f84b52dd01bc96124b8bcb2c31891cf27c5f325fdfa
    lastState:
      terminated:
        containerID: docker://ba34fa66001a517c68cb40a05e8074bc283389b0d01b19fa16be1aa9b3de1df0
        exitCode: 126
        finishedAt: "2022-07-28T06:18:19Z"
        message: 'OCI runtime create failed: container_linux.go:380: starting container
          process caused: exec: "/coredns": permission denied: unknown'
        reason: ContainerCannotRun
        startedAt: "2022-07-28T06:18:19Z"
    name: chaos-dns-server
    ready: false
    restartCount: 2
    started: false
    state:
      waiting:
        message: 'failed to start container "ba34fa66001a517c68cb40a05e8074bc283389b0d01b19fa16be1aa9b3de1df0":
          Error response from daemon: OCI runtime create failed: container_linux.go:380:
          starting container process caused: exec: "/coredns": permission denied:
          unknown'
        reason: RunContainerError

@STRRL
Copy link
Member

STRRL commented Aug 12, 2022

/merge cancel

hack/run-e2e.sh Outdated Show resolved Hide resolved
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
hack/run-e2e.sh Outdated Show resolved Hide resolved
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
helm/chaos-mesh/values.yaml Outdated Show resolved Hide resolved
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
@STRRL
Copy link
Member

STRRL commented Mar 9, 2023

@cwen0 @YangKeao @STRRL @xlgao-zju After debugging, I found that the coredns version is the reason for the failed e2e tests.

So in chaos-mesh/k8s_dns_chaos@07dc8bd, I revert the version to the specific commit and upload the latest version to test in this PR. All related DNSChaos tests are passed.

If there are no other questions, we can release a new version (v0.2.5) of chaos-coredns and update this PR.

hmm it still does not work, I would take a look later..

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
…te as default

Signed-off-by: STRRL <im@strrl.dev>
Signed-off-by: STRRL <im@strrl.dev>
@STRRL
Copy link
Member

STRRL commented Mar 10, 2023

@cwen0 @YangKeao @STRRL @xlgao-zju After debugging, I found that the coredns version is the reason for the failed e2e tests.
So in chaos-mesh/k8s_dns_chaos@07dc8bd, I revert the version to the specific commit and upload the latest version to test in this PR. All related DNSChaos tests are passed.
If there are no other questions, we can release a new version (v0.2.5) of chaos-coredns and update this PR.

hmm it still does not work, I would take a look later..

Hi, I think I resolved the issue and am releasing a new version of chaos-coredns: chaos-mesh/k8s_dns_chaos#24

This PR would get merged if it could all the testcases.

@g1eny0ung
Copy link
Member

Great!

$KIND_BIN load docker-image --name $CLUSTER pingcap/coredns:v0.2.0 --nodes $(hack::join ',' ${nodes[@]})
$KIND_BIN load docker-image --name $CLUSTER nginx:latest --nodes $(hack::join ',' ${nodes[@]})
$KIND_BIN load docker-image --name $CLUSTER gcr.io/google-containers/pause:latest --nodes $(hack::join ',' ${nodes[@]})
$KIND_BIN load docker-image --name "$CLUSTER" ghcr.io/chaos-mesh/chaos-coredns:v0.2.6 --nodes "$(hack::join ',' ${nodes[@]})"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

46% of developers fix this issue

SC2068: Double quote array expansions to avoid re-splitting elements.


ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage
@sonatype-lift ignore Leave out the above finding from this PR
@sonatype-lift ignoreall Leave out all the existing findings from this PR
@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.


Help us improve LIFT! (Sonatype LiftBot external survey)

Was this a good recommendation for you? Answering this survey will not impact your Lift settings.

[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sonatype-lift ignore

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've recorded this as ignored for this pull request.
If you change your mind, just comment @sonatype-lift unignore.

Signed-off-by: STRRL <im@strrl.dev>
@xlgao-zju
Copy link
Member

coooool!!!!

@STRRL
Copy link
Member

STRRL commented Mar 10, 2023

/unhold

@STRRL
Copy link
Member

STRRL commented Mar 10, 2023

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e34b303

@g1eny0ung g1eny0ung merged commit 59f76b4 into chaos-mesh:master Mar 10, 2023
chaotic-prow bot pushed a commit that referenced this pull request May 17, 2023
* install offline Helm Chart for multi cluster

Signed-off-by: nio <nioshield@gmail.com>

* fix remotecluster current version

Signed-off-by: nio <nioshield@gmail.com>

* chore: bump ginkgo version in dev-env to v2 (#3923)

Signed-off-by: STRRL <im@strrl.dev>
Signed-off-by: nio <nioshield@gmail.com>

* Update install.sh to work on macos (#3901)

* Update install.sh to work on macos

The default bash version on MacOS does not support
reading an array directly from a variable. Instead, use
`read -a` to accomplish separating version numbers.

Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>

* chore: update changelog

Signed-off-by: STRRL <im@strrl.dev>

---------

Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
Signed-off-by: STRRL <im@strrl.dev>
Co-authored-by: STRRL <im@strrl.dev>
Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Signed-off-by: nio <nioshield@gmail.com>

* update chaos-coredns version to v0.2.4 (#3947)

* update chaos-coredns version to v0.2.4

Signed-off-by: Xianglin Gao <xianglingao@tencent.com>

* update chaos-coredns version to v0.2.4

Signed-off-by: Xianglin Gao <xianglingao@tencent.com>

---------

Signed-off-by: Xianglin Gao <xianglingao@tencent.com>
Signed-off-by: nio <nioshield@gmail.com>

* Revert "update chaos-coredns version to v0.2.4" (#3967)

This reverts commit b031d88.

Signed-off-by: nio <nioshield@gmail.com>

* refactor(ui): use pnpm package manager (#3965)

* chore: init

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>

* test: add jest-dom types

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>

* fix: add @mui/base

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>

* fix: types

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>

* chore: update

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>

* chore: clear yarn usage

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>

* chore: update changelog

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>

* fix: update storyshots

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>

* fix: downgrade react-testing-library

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>

* fix: @ui/app tests

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>

* fix: unknown unsafe-perm

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>

---------

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: nio <nioshield@gmail.com>

* upgrade dns coredns image url to ghcr.io (#3488)

* upgrade dns coredns image url to ghcr.io

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>

* add CHANGELOG

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>

* replace pingcap project with chaos-mesh

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>

* add back  docker-push-dns-server

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>

* chore: bump the version of chaos-coredns to v0.2.2

Signed-off-by: STRRL <im@strrl.dev>

* update Makefile

Signed-off-by: Cwen Yin <cwenyin0@gmail.com>

* chore: bump coredns image version to 0.2.4

Signed-off-by: STRRL <im@strrl.dev>

* test: use latest image

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>

* fix: follow sonatype-lift suggestions

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>

* chore: update chaos-coredns to v0.2.5

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>

* fix: changelog

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>

* fix: typo

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>

* fix: update dnsServer.image

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>

* fix: remove pingcap

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>

* fix: typo

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>

* fix: add ghcr.io registry

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>

* Rename ChaosDNSImage to ChaosCoreDNSImage

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>

* feat: bump chaos-coredns version to v0.2.6, and enable dnsServer.create as default

Signed-off-by: STRRL <im@strrl.dev>

* chore: update the helm chart configs

Signed-off-by: STRRL <im@strrl.dev>

* chore: make check

Signed-off-by: STRRL <im@strrl.dev>

---------

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
Signed-off-by: STRRL <im@strrl.dev>
Signed-off-by: Cwen Yin <cwenyin0@gmail.com>
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Co-authored-by: STRRL <im@strrl.dev>
Co-authored-by: Cwen Yin <cwenyin0@gmail.com>
Co-authored-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: nio <nioshield@gmail.com>

* fix: supplement read-only token (#3971)

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: nio <nioshield@gmail.com>

* fix: migrate from k8s.gcr.io to registry.k8s.io (#3974)

Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
Signed-off-by: nio <nioshield@gmail.com>

* Update pkg/helm/chart.go

Co-authored-by: Zhou Zhiqiang <im@strrl.dev>
Signed-off-by: nio <nioshield@gmail.com>

---------

Signed-off-by: nio <nioshield@gmail.com>
Signed-off-by: STRRL <im@strrl.dev>
Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
Signed-off-by: Xianglin Gao <xianglingao@tencent.com>
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
Signed-off-by: Cwen Yin <cwenyin0@gmail.com>
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
Co-authored-by: Zhou Zhiqiang <im@strrl.dev>
Co-authored-by: Blaine Gardner <b.blaine.gardner@gmail.com>
Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Co-authored-by: Xianglin Gao <xianglingao@tencent.com>
Co-authored-by: Yue Yang <g1enyy0ung@gmail.com>
Co-authored-by: YangKeao <yangkeao@chunibyo.icu>
Co-authored-by: Cwen Yin <cwenyin0@gmail.com>
Co-authored-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants