-
Notifications
You must be signed in to change notification settings - Fork 803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade dns coredns image url to ghcr.io #3488
upgrade dns coredns image url to ghcr.io #3488
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
4413ebe
to
016044f
Compare
Codecov Report
@@ Coverage Diff @@
## master #3488 +/- ##
==========================================
+ Coverage 38.50% 38.56% +0.05%
==========================================
Files 165 165
Lines 13698 13698
==========================================
+ Hits 5275 5283 +8
+ Misses 7992 7983 -9
- Partials 431 432 +1 see 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
…upgrade-dns-coredns-image
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
/merge |
@YangKeao: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/hold This PR cannot pass the CI. I'll fix it later. |
I found
I found that the I download logs from artifacts: https://github.com/chaos-mesh/chaos-mesh/actions/runs/2751672468 the container is not ready, with status:
|
/merge cancel |
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
hmm it still does not work, I would take a look later.. |
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
…te as default Signed-off-by: STRRL <im@strrl.dev>
Signed-off-by: STRRL <im@strrl.dev>
Hi, I think I resolved the issue and am releasing a new version of chaos-coredns: chaos-mesh/k8s_dns_chaos#24 This PR would get merged if it could all the testcases. |
Great! |
$KIND_BIN load docker-image --name $CLUSTER pingcap/coredns:v0.2.0 --nodes $(hack::join ',' ${nodes[@]}) | ||
$KIND_BIN load docker-image --name $CLUSTER nginx:latest --nodes $(hack::join ',' ${nodes[@]}) | ||
$KIND_BIN load docker-image --name $CLUSTER gcr.io/google-containers/pause:latest --nodes $(hack::join ',' ${nodes[@]}) | ||
$KIND_BIN load docker-image --name "$CLUSTER" ghcr.io/chaos-mesh/chaos-coredns:v0.2.6 --nodes "$(hack::join ',' ${nodes[@]})" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SC2068: Double quote array expansions to avoid re-splitting elements.
ℹ️ Expand to see all @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
Command | Usage |
---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
Help us improve LIFT! (Sonatype LiftBot external survey)
Was this a good recommendation for you? Answering this survey will not impact your Lift settings.
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sonatype-lift ignore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've recorded this as ignored for this pull request.
If you change your mind, just comment @sonatype-lift unignore
.
Signed-off-by: STRRL <im@strrl.dev>
coooool!!!! |
/unhold |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: e34b303
|
* install offline Helm Chart for multi cluster Signed-off-by: nio <nioshield@gmail.com> * fix remotecluster current version Signed-off-by: nio <nioshield@gmail.com> * chore: bump ginkgo version in dev-env to v2 (#3923) Signed-off-by: STRRL <im@strrl.dev> Signed-off-by: nio <nioshield@gmail.com> * Update install.sh to work on macos (#3901) * Update install.sh to work on macos The default bash version on MacOS does not support reading an array directly from a variable. Instead, use `read -a` to accomplish separating version numbers. Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com> * chore: update changelog Signed-off-by: STRRL <im@strrl.dev> --------- Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com> Signed-off-by: STRRL <im@strrl.dev> Co-authored-by: STRRL <im@strrl.dev> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io> Signed-off-by: nio <nioshield@gmail.com> * update chaos-coredns version to v0.2.4 (#3947) * update chaos-coredns version to v0.2.4 Signed-off-by: Xianglin Gao <xianglingao@tencent.com> * update chaos-coredns version to v0.2.4 Signed-off-by: Xianglin Gao <xianglingao@tencent.com> --------- Signed-off-by: Xianglin Gao <xianglingao@tencent.com> Signed-off-by: nio <nioshield@gmail.com> * Revert "update chaos-coredns version to v0.2.4" (#3967) This reverts commit b031d88. Signed-off-by: nio <nioshield@gmail.com> * refactor(ui): use pnpm package manager (#3965) * chore: init Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * test: add jest-dom types Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * fix: add @mui/base Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * fix: types Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * chore: update Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * chore: clear yarn usage Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * chore: update changelog Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * fix: update storyshots Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * fix: downgrade react-testing-library Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * fix: @ui/app tests Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * fix: unknown unsafe-perm Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> --------- Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> Signed-off-by: nio <nioshield@gmail.com> * upgrade dns coredns image url to ghcr.io (#3488) * upgrade dns coredns image url to ghcr.io Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * add CHANGELOG Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * replace pingcap project with chaos-mesh Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * add back docker-push-dns-server Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * chore: bump the version of chaos-coredns to v0.2.2 Signed-off-by: STRRL <im@strrl.dev> * update Makefile Signed-off-by: Cwen Yin <cwenyin0@gmail.com> * chore: bump coredns image version to 0.2.4 Signed-off-by: STRRL <im@strrl.dev> * test: use latest image Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * fix: follow sonatype-lift suggestions Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * chore: update chaos-coredns to v0.2.5 Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * fix: changelog Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * fix: typo Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * fix: update dnsServer.image Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * fix: remove pingcap Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * fix: typo Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * fix: add ghcr.io registry Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * Rename ChaosDNSImage to ChaosCoreDNSImage Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * feat: bump chaos-coredns version to v0.2.6, and enable dnsServer.create as default Signed-off-by: STRRL <im@strrl.dev> * chore: update the helm chart configs Signed-off-by: STRRL <im@strrl.dev> * chore: make check Signed-off-by: STRRL <im@strrl.dev> --------- Signed-off-by: YangKeao <yangkeao@chunibyo.icu> Signed-off-by: STRRL <im@strrl.dev> Signed-off-by: Cwen Yin <cwenyin0@gmail.com> Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io> Co-authored-by: STRRL <im@strrl.dev> Co-authored-by: Cwen Yin <cwenyin0@gmail.com> Co-authored-by: Yue Yang <g1enyy0ung@gmail.com> Signed-off-by: nio <nioshield@gmail.com> * fix: supplement read-only token (#3971) Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> Signed-off-by: nio <nioshield@gmail.com> * fix: migrate from k8s.gcr.io to registry.k8s.io (#3974) Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com> Signed-off-by: nio <nioshield@gmail.com> * Update pkg/helm/chart.go Co-authored-by: Zhou Zhiqiang <im@strrl.dev> Signed-off-by: nio <nioshield@gmail.com> --------- Signed-off-by: nio <nioshield@gmail.com> Signed-off-by: STRRL <im@strrl.dev> Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com> Signed-off-by: Xianglin Gao <xianglingao@tencent.com> Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> Signed-off-by: YangKeao <yangkeao@chunibyo.icu> Signed-off-by: Cwen Yin <cwenyin0@gmail.com> Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com> Co-authored-by: Zhou Zhiqiang <im@strrl.dev> Co-authored-by: Blaine Gardner <b.blaine.gardner@gmail.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io> Co-authored-by: Xianglin Gao <xianglingao@tencent.com> Co-authored-by: Yue Yang <g1enyy0ung@gmail.com> Co-authored-by: YangKeao <yangkeao@chunibyo.icu> Co-authored-by: Cwen Yin <cwenyin0@gmail.com> Co-authored-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
Signed-off-by: YangKeao yangkeao@chunibyo.icu
What problem does this PR solve?
DNSChaos
supports arm64 now!What's changed and how it works?
pingcap
project intochaos-mesh
project.