Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "update chaos-coredns version to v0.2.4" #3967

Merged
merged 1 commit into from
Mar 8, 2023

Conversation

g1eny0ung
Copy link
Member

@xlgao-zju @STRRL Reverts #3947

This PR has not passed the e2e tests, and there has been a pioneer working on this problem in #3488.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 8, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • STRRL

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@xlgao-zju
Copy link
Member

oops, I see...

but why will ghcr.io/chaos-mesh/chaos-coredns:v0.2.4 break the e2e test?

@STRRL
Copy link
Member

STRRL commented Mar 8, 2023

oops, I see...

but why will ghcr.io/chaos-mesh/chaos-coredns:v0.2.4 break the e2e test?

I am not sure.. will profile it deeper later...

@STRRL
Copy link
Member

STRRL commented Mar 8, 2023

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: c96d7b4

Copy link
Member

@xlgao-zju xlgao-zju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot merged commit 23b8b55 into master Mar 8, 2023
@g1eny0ung g1eny0ung deleted the revert-3947-update-dns-024 branch March 8, 2023 07:29
chaotic-prow bot pushed a commit that referenced this pull request May 17, 2023
* install offline Helm Chart for multi cluster

Signed-off-by: nio <nioshield@gmail.com>

* fix remotecluster current version

Signed-off-by: nio <nioshield@gmail.com>

* chore: bump ginkgo version in dev-env to v2 (#3923)

Signed-off-by: STRRL <im@strrl.dev>
Signed-off-by: nio <nioshield@gmail.com>

* Update install.sh to work on macos (#3901)

* Update install.sh to work on macos

The default bash version on MacOS does not support
reading an array directly from a variable. Instead, use
`read -a` to accomplish separating version numbers.

Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>

* chore: update changelog

Signed-off-by: STRRL <im@strrl.dev>

---------

Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
Signed-off-by: STRRL <im@strrl.dev>
Co-authored-by: STRRL <im@strrl.dev>
Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Signed-off-by: nio <nioshield@gmail.com>

* update chaos-coredns version to v0.2.4 (#3947)

* update chaos-coredns version to v0.2.4

Signed-off-by: Xianglin Gao <xianglingao@tencent.com>

* update chaos-coredns version to v0.2.4

Signed-off-by: Xianglin Gao <xianglingao@tencent.com>

---------

Signed-off-by: Xianglin Gao <xianglingao@tencent.com>
Signed-off-by: nio <nioshield@gmail.com>

* Revert "update chaos-coredns version to v0.2.4" (#3967)

This reverts commit b031d88.

Signed-off-by: nio <nioshield@gmail.com>

* refactor(ui): use pnpm package manager (#3965)

* chore: init

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>

* test: add jest-dom types

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>

* fix: add @mui/base

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>

* fix: types

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>

* chore: update

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>

* chore: clear yarn usage

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>

* chore: update changelog

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>

* fix: update storyshots

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>

* fix: downgrade react-testing-library

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>

* fix: @ui/app tests

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>

* fix: unknown unsafe-perm

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>

---------

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: nio <nioshield@gmail.com>

* upgrade dns coredns image url to ghcr.io (#3488)

* upgrade dns coredns image url to ghcr.io

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>

* add CHANGELOG

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>

* replace pingcap project with chaos-mesh

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>

* add back  docker-push-dns-server

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>

* chore: bump the version of chaos-coredns to v0.2.2

Signed-off-by: STRRL <im@strrl.dev>

* update Makefile

Signed-off-by: Cwen Yin <cwenyin0@gmail.com>

* chore: bump coredns image version to 0.2.4

Signed-off-by: STRRL <im@strrl.dev>

* test: use latest image

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>

* fix: follow sonatype-lift suggestions

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>

* chore: update chaos-coredns to v0.2.5

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>

* fix: changelog

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>

* fix: typo

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>

* fix: update dnsServer.image

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>

* fix: remove pingcap

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>

* fix: typo

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>

* fix: add ghcr.io registry

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>

* Rename ChaosDNSImage to ChaosCoreDNSImage

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>

* feat: bump chaos-coredns version to v0.2.6, and enable dnsServer.create as default

Signed-off-by: STRRL <im@strrl.dev>

* chore: update the helm chart configs

Signed-off-by: STRRL <im@strrl.dev>

* chore: make check

Signed-off-by: STRRL <im@strrl.dev>

---------

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
Signed-off-by: STRRL <im@strrl.dev>
Signed-off-by: Cwen Yin <cwenyin0@gmail.com>
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Co-authored-by: STRRL <im@strrl.dev>
Co-authored-by: Cwen Yin <cwenyin0@gmail.com>
Co-authored-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: nio <nioshield@gmail.com>

* fix: supplement read-only token (#3971)

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: nio <nioshield@gmail.com>

* fix: migrate from k8s.gcr.io to registry.k8s.io (#3974)

Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
Signed-off-by: nio <nioshield@gmail.com>

* Update pkg/helm/chart.go

Co-authored-by: Zhou Zhiqiang <im@strrl.dev>
Signed-off-by: nio <nioshield@gmail.com>

---------

Signed-off-by: nio <nioshield@gmail.com>
Signed-off-by: STRRL <im@strrl.dev>
Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
Signed-off-by: Xianglin Gao <xianglingao@tencent.com>
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
Signed-off-by: Cwen Yin <cwenyin0@gmail.com>
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
Co-authored-by: Zhou Zhiqiang <im@strrl.dev>
Co-authored-by: Blaine Gardner <b.blaine.gardner@gmail.com>
Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Co-authored-by: Xianglin Gao <xianglingao@tencent.com>
Co-authored-by: Yue Yang <g1enyy0ung@gmail.com>
Co-authored-by: YangKeao <yangkeao@chunibyo.icu>
Co-authored-by: Cwen Yin <cwenyin0@gmail.com>
Co-authored-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants