feat: OIDC authentication support #4427
Open
+277
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ivar Cmrecak <ivar.cmrecak@lego.com>
davidbrown-wk
approved these changes
Jun 7, 2024
g1eny0ung
reviewed
Jun 11, 2024
| "golang.org/x/oauth2" | ||
| ) | ||
|
|
||
| func setCookie(c *gin.Context, token *oauth2.Token) { |
There was a problem hiding this comment.
The setCookie has already been defined in gcp package, it's better to extract a public method instead of making a copy of it.
g1eny0ung
reviewed
Jun 11, 2024
| ctx := c.Request.Context() | ||
|
|
||
| s.logger.Info("handling oidc middleware") | ||
| if c.Request.Header.Get("X-Authorization-Method") != "gcp" { |
There was a problem hiding this comment.
This part of the code should be updated. We can use oidc as the X-Authorization-Method. At the same time, we also need to update the frontend to adapt it.
There was a problem hiding this comment.
Or we can use oauth to unify all OAuth-based authorization.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Close #4141
What's changed and how it works?
Adds frontend and backend support for Kubernetes OIDC authentication
Related changes
UI interfaceCherry-pick to release branches (optional)
Checklist
CHANGELOG
CHANGELOG.mdTests
Side effects
DCO
If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it: