-
Notifications
You must be signed in to change notification settings - Fork 822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add host-network flag in install.sh #954
Conversation
Signed-off-by: shonge <soog2008@hotmail.com>
Signed-off-by: shonge <soog2008@hotmail.com>
93d34fc
to
0859dce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
@shonge Can you fix the conflicts? Thanks! |
@shonge,Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments.See the corresponding SIG page for more information. Related SIG: chaos-mesh(slack). |
update |
Codecov Report
@@ Coverage Diff @@
## master #954 +/- ##
==========================================
- Coverage 55.78% 48.20% -7.58%
==========================================
Files 68 74 +6
Lines 4383 4435 +52
==========================================
- Hits 2445 2138 -307
- Misses 1768 2081 +313
- Partials 170 216 +46
Continue to review full report at Codecov.
|
@cwen0 @WangXiangUSTC PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
/run-all-tests |
cherry pick to release-1.0 failed |
What problem does this PR solve?
Fix #835
What is changed and how does it work?
Checklist
Tests
Side effects
Related changes
Does this PR introduce a user-facing change?