Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add host-network flag in install.sh #954

Merged
merged 8 commits into from
Oct 10, 2020
Merged

add host-network flag in install.sh #954

merged 8 commits into from
Oct 10, 2020

Conversation

shonge
Copy link
Contributor

@shonge shonge commented Sep 23, 2020 •
edited
Loading

What problem does this PR solve?

Fix #835

What is changed and how does it work?

Checklist

Tests

  • Manual test (add detailed scripts or steps below)
./install.sh --host-network --template
kubectl  -n chaos-testing get deploy chaos-controller-manager -o jsonpath='{.spec.template.spec.hostNetwork}'
true
kubectl  -n chaos-testing get ds chaos-daemon -o jsonpath='{.spec.template.spec.hostNetwork}'
true

Side effects

  • Breaking backward compatibility

Related changes

  • Need to update the documentation

Does this PR introduce a user-facing change?

add --host-network flag in install.sh

@shonge
add host-network flag
b4735a4 
Signed-off-by: shonge <soog2008@hotmail.com>
@shonge
add hostnetwork in check-install-script
0859dce 
Signed-off-by: shonge <soog2008@hotmail.com>
cwen0
cwen0 previously approved these changes Sep 27, 2020
View reviewed changes
Copy link
Member

@cwen0 cwen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@cwen0
Copy link
Member

cwen0 commented Sep 27, 2020

@shonge Can you fix the conflicts? Thanks!

@ti-srebot
Copy link
Contributor

@shonge,Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments.See the corresponding SIG page for more information. Related SIG: chaos-mesh(slack).

@shonge shonge closed this Oct 9, 2020
@shonge shonge reopened this Oct 9, 2020
@shonge
Copy link
Contributor Author

shonge commented Oct 9, 2020

@shonge Can you fix the conflicts? Thanks!

update

@codecov-io
Copy link

codecov-io commented Oct 9, 2020 •
edited
Loading

Codecov Report

Merging #954 into master will decrease coverage by 7.57%.
The diff coverage is 29.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #954      +/-   ##
==========================================
- Coverage   55.78%   48.20%   -7.58%     
==========================================
  Files          68       74       +6     
  Lines        4383     4435      +52     
==========================================
- Hits         2445     2138     -307     
- Misses       1768     2081     +313     
- Partials      170      216      +46
Impacted Files Coverage Δ
api/v1alpha1/common_validation.go 100.00% <ø> (ø)
api/v1alpha1/common_webhook.go 100.00% <ø> (ø)
api/v1alpha1/iochaos_types.go 37.03% <0.00%> (-2.97%) ⬇️
api/v1alpha1/kernelchaos_types.go 18.51% <0.00%> (-1.49%) ⬇️
api/v1alpha1/kernelchaos_webhook.go 84.21% <ø> (-0.98%) ⬇️
api/v1alpha1/kinds.go 27.27% <ø> (+0.60%) ⬆️
api/v1alpha1/networkchaos_types.go 19.54% <0.00%> (-3.44%) ⬇️
api/v1alpha1/podchaos_types.go 33.33% <0.00%> (-3.81%) ⬇️
api/v1alpha1/podchaos_webhook.go 80.76% <ø> (-1.20%) ⬇️
api/v1alpha1/podiochaos_webhook.go 0.00% <0.00%> (ø)
... and 119 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 847923e...6ec9907. Read the comment docs.

@zhouqiang-cl
Copy link
Contributor

@cwen0 @WangXiangUSTC PTAL

WangXiangUSTC
WangXiangUSTC approved these changes Oct 10, 2020
View reviewed changes
Copy link
Contributor

@WangXiangUSTC WangXiangUSTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cwen0
Copy link
Member

cwen0 commented Oct 10, 2020

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit d578cb9 into chaos-mesh:master Oct 10, 2020
@ti-srebot
Copy link
Contributor

cherry pick to release-1.0 failed

@mikechengwei mikechengwei mentioned this pull request Oct 10, 2020
Merged
cwen0 pushed a commit to cwen0/chaos-mesh that referenced this pull request Oct 13, 2020
@shonge @cwen0
add host-network flag in install.sh (chaos-mesh#954)
d2bd704
cwen0 added a commit that referenced this pull request Oct 13, 2020
@cwen0 @shonge @mikechengwei
cherry-pick pr 954 (#1044)
cc288f0 
* add host-network flag in install.sh (#954)

* fix install shell bug (#1028)

Co-authored-by: Ge Song <soog2008@hotmail.com>
Co-authored-by: Mike <842725815@qq.com>
sjwsl pushed a commit to sjwsl/chaos-mesh that referenced this pull request May 6, 2021
@shonge
add host-network flag in install.sh (chaos-mesh#954)
02ca5dc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WangXiangUSTC WangXiangUSTC WangXiangUSTC approved these changes

@cwen0 cwen0 cwen0 approved these changes

@ti-srebot ti-srebot ti-srebot approved these changes

Assignees
No one assigned
Labels
component/scripts contribution status/can-merge status/LGT2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a flag to control if chaos-daemon use hostNetwork in install.sh
6 participants
@shonge @cwen0 @ti-srebot @codecov-io @zhouqiang-cl @WangXiangUSTC