Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a simple http server for current directory #10

Closed
wants to merge 2 commits into from
Closed

Adding a simple http server for current directory #10

wants to merge 2 commits into from

Conversation

richardanaya
Copy link
Contributor

Here's a simple server, however, I don't know how to best call this process cleanly from the main chaos.py.

@Ameliorate
Copy link
Contributor

Ameliorate commented May 23, 2017

This is a very bad idea. In the current directory is the github_pat.secret file, which contains the github secret. Having a http server serving the CD would allow this file to be viewed by anyone, and someone will steal the account and derail the bot. 👎

@amoffat
Copy link
Contributor

amoffat commented May 23, 2017

Bingo @Ameliorate. If this was changed to prevent serving that file, or if we could confirm that if that file was moved up to the parent directory, SimpleHTTPRequestHandler would not be able to access it, then there's no issue

@richardanaya
Copy link
Contributor Author

oh, thanks! sorry about that, still figuring out the environment

amoffat added a commit to amoffat/Chaos that referenced this pull request May 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants