Fallback #120
Merged
Fallback #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 24, 2017 01:23
- Actual revert not yet implemented
|
I mean it fits the name chaos. But the thought of adding a commit revert wind up clock makes me uncomfortable. However I am interested in the idea of being able to revert a commit via api |
|
@MINIMAN10000 I can't say I'd ever want it to happen myself, but I like the idea of the threat being there 😛 |
- Update date variable to reflect that deltatime does not have an hour attribute
|
(updated description & title) |
phil-r
reviewed
May 24, 2017
github_api/repos.py
Outdated
| if(len(data) > 0) | ||
| # return previous commit sha if it exists | ||
| if(len(data) >= 1) | ||
| data[0]['last_commit_sha'] = |
There was a problem hiding this comment.
Quite right, thanks for spotting that. I thought I'd removed it.
|
🙆♀️ PR passed with a vote of 7 for and 3 against, with a weighted total of 4.0 and a threshold of 3.6. See merge-commit bffbc96 for more details. |
chaosbot
added a commit
that referenced
this pull request
May 25, 2017
chaosbot
added a commit
that referenced
this pull request
May 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has become a little more ominous than the original intention, which was to revert the most recent PR if no PR has been approved in the last 24 hours. I found that this was not something that could be done via the API, and so I propose a new consequence for inaction:
If no PR has been approved in the last 24 hours, Chaos randomly chooses a PR with no conflicts, and merges it in spite of the current vote.
The main purpose of this is to encourage progress (I'm afraid of the result of this PR myself), and of course introduce some chaos. This PR ensures that there will always be a discussion to be had.
Extra bonus: this PR includes a little class for handling commit objects, might come in handy for others.