Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

forms look a bit off #86

Closed
YtvwlD opened this issue Jan 19, 2020 · 4 comments · Fixed by #88
Closed

forms look a bit off #86

YtvwlD opened this issue Jan 19, 2020 · 4 comments · Fixed by #88
Labels
bug

Comments

@YtvwlD
Copy link
Member

YtvwlD commented Jan 19, 2020

Ever since the switch to Bootstrap 4 thought that the forms look a bit off, but I couldn't really pin point it.

Today I think I found the problem: the CSS classes generated by formtastic-bootstrap are not the ones Bootstrap expects.

In normal operation, this is not too bad (considering that the last release of formtastic-bootstrap happened in 2015 and that the repository has been archived on GitHub), but when you encounter validation errors you see that something is clearly wrong.

I'm not sure about the way forward. The last release of formtastic itself happened in 2017.
@YtvwlD YtvwlD added the bug label Jan 19, 2020
@nomaster
Copy link
Member

Maybe we could use Simple Form?

Most of the DSL was inherited from Formtastic

So it might be just a drop-in replacement.

YtvwlD added a commit to YtvwlD/mete that referenced this issue Jan 22, 2020
@YtvwlD
💄 Replace Formtastic with Simple Form (closes chaosdorf#86)
1fef242
@YtvwlD
Copy link
Member Author

YtvwlD commented Jan 22, 2020

It's not exactly a drop-in replacement, but pretty similar.

@YtvwlD
Copy link
Member Author

YtvwlD commented Jul 14, 2020

FWIW there seems to be a new formtastic release in the making.

@YtvwlD YtvwlD linked a pull request Mar 8, 2021 that will close this issue
💄 Replace Formtastic with Simple Form (closes #86) #88
Merged
@YtvwlD
Copy link
Member Author

YtvwlD commented Mar 8, 2021

Well, the new Formtastic version breaks when upgrading, so I had to pin the old version in 65e2246.

@YtvwlD YtvwlD closed this as completed in 6e2e1ce Mar 9, 2021
YtvwlD added a commit that referenced this issue Mar 9, 2021
@YtvwlD
🔀 Merge pull request #88 from YtvwlD/simple-form
7c1a584 
💄 Replace Formtastic with Simple Form (closes #86)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

💄 Replace Formtastic with Simple Form (closes #86) YtvwlD/mete
2 participants
@nomaster @YtvwlD