Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

💄 Replace Formtastic with Simple Form (closes #86) #88

Merged
merged 1 commit into from
Mar 9, 2021
Merged

💄 Replace Formtastic with Simple Form (closes #86) #88

merged 1 commit into from
Mar 9, 2021

Conversation

YtvwlD
Copy link
Member

@YtvwlD YtvwlD commented Jan 22, 2020

No description provided.

@YtvwlD YtvwlD requested a review from nomaster January 22, 2020 10:18
nomaster
nomaster approved these changes Jan 23, 2020
View reviewed changes
Copy link
Member

@nomaster nomaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good - haven't looked at the resulting UI, though.

@nomaster nomaster mentioned this pull request Jan 23, 2020
Draft
@YtvwlD YtvwlD linked an issue Mar 8, 2021 that may be closed by this pull request
forms look a bit off #86
Closed
@YtvwlD
Copy link
Member Author

YtvwlD commented Mar 8, 2021

With regards to the UI, here's a screenshot:

before after
grafik grafik

So, I think we should get this merged. (Why didn't I do this already?)

I've already rebased it to master.

@YtvwlD YtvwlD merged commit 7c1a584 into chaosdorf:master Mar 9, 2021
@YtvwlD YtvwlD deleted the simple-form branch March 9, 2021 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nomaster nomaster nomaster approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

forms look a bit off
2 participants
@YtvwlD @nomaster