Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Porting manuscripts to use new functions and classes added in #67 #70

Closed
aswanipranjal opened this issue Jul 6, 2018 · 3 comments
Closed

Comments

@aswanipranjal
Copy link
Contributor

I've tried to create more chain-able functions/classes to be able to calculate the metrics. They are added as manuscripts2 through #67.

This issue is about calculating the current metrics, that manuscripts produces, using these new functions/classes.
My approach will be to use the flow that is currently being used.

  • Create classes for each of the data source
  • Create sections of the report
  • Calculate the metrics in each section using the above classes
  • Generate the report.

In addition, this new report will mostly use Markdown instead of Latex.

@jgbarah
Copy link
Contributor

jgbarah commented Jul 6, 2018

I think we can use this issue just for the production of the CSV files. If you want, also the charts, since that's quite similar. For the report itself, we can iterate in some other issue, or maybe in two in parallel, one reusing the current work with LaTeX, the other one for Markdown.

@jgbarah
Copy link
Contributor

jgbarah commented Jul 6, 2018

This said, try to start small. Instead of submitting a PR with all the intended functionality, select just a few metrics, and produce the corresponding CSV. That would allow us to discuss changes in the architecture with easy: you won't need to change the code for a lot of metrics if we decide to make changes to the architecture.

@aswanipranjal
Copy link
Contributor Author

aswanipranjal commented Aug 7, 2018

By adding PRs #88 to #104 (and all the PRs in between), the CSV files can now be generated using manuscripts2. I am closing this issue and creating a new one where the PDF generation can be discussed.

Continued in #105

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants