Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Git] Won't delete the old tags when calling __fetch_newest_commits_from_repo #782

Closed
xiao623 opened this issue May 9, 2022 · 2 comments
Labels
bug git good first issue Good issue for first-time contributors

Comments

@xiao623
Copy link
Contributor

xiao623 commented May 9, 2022

# Delete old references
for old_ref in self._discover_refs():
if not old_ref.refname.startswith('refs/heads/'):
continue
if old_ref.refname in new_refs:
continue
self._update_ref(old_ref, delete=True)

It seems that it will only delete those old references (refs/heads/*) and will not delete these old references (refs/tags/*).

If the server deletes the tag, should the tag of the local repo be deleted?

@sduenas sduenas added bug git good first issue Good issue for first-time contributors labels Oct 11, 2023
@vchrombie
Copy link
Member

Since #845 is merged, I guess we can close this.

@sduenas
Copy link
Member

sduenas commented Aug 22, 2024

Good catch!. Closing it.

@sduenas sduenas closed this as completed Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug git good first issue Good issue for first-time contributors
Projects
None yet
Development

No branches or pull requests

3 participants