This repository has been archived by the owner on Jun 15, 2023. It is now read-only.
Allow object to be specified as the controller in a route match statemen... #846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ment (e.g. `match 'foo', controller: FooController, action: 'show'`).
|
I like this simple approach to solving dynamic requires. Great job! |
|
I second this change. I am trying to get a new project started with webpack and chaplin and I just can't get it working. Can you please merge this change in as part of the next release? |
paulmillr
added a commit
that referenced
this pull request
Feb 21, 2015
Allow object to be specified as the controller in a route match statemen...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very simple change to allow object to be specified as the controller in a route match statement (e.g.
match 'foo', controller: FooController, action: 'show'), if the object is given it is returned immediately byloadControllersince it is already loaded. If the parameter is anything else the previous behavior applies. This enables chaplin to work with tools like webpack and browserify where dynamic requires cause problems.