New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Next.js draft mode #502

Closed

JohnAlbin opened this issue May 30, 2023 · 3 comments

Labels

area: next module area: next-drupal enhancement

Milestone

next-drupal 2.0.0

Collaborator

JohnAlbin commented May 30, 2023

The new App Router feature of Next.js 13.4 doesn't work with the old Preview Mode API. Instead Next.js apps that use the App directory need to use the new Draft Mode feature.

Here's a blog post mentioning the Draft Mode feature (under "other improvements") included with Next.js 13.4: https://nextjs.org/blog/next-13-4#other-improvements

And here is Next.js' Draft Mode documentation

This request is related to #442, but that issue specifically mentions the Server Components part of the App Router feature and Draft Mode isn't related to Server Components.

dottodot commented Sep 1, 2023

Draft mode is also recommended for pages too https://nextjs.org/docs/pages/building-your-application/configuring/draft-mode but the implementations are slightly different which would need to be taken into account.

Also there doesn't seem to be a replacement for setPreviewData so revisions will need a rethink.

JohnAlbin added the enhancement label

JohnAlbin added the area: next module label

JohnAlbin added the area: next-drupal label

JohnAlbin modified the milestones: next 2.0.0, next-drupal 2.0.0

Collaborator Author

JohnAlbin commented Jan 6, 2024

@dottodot Thanks so much for the link!

Somehow I had missed that Draft Mode was recommended for pages router. That simplifies what next-drupal needs to support when a website is only partially migrated from pages router to app router.

JohnAlbin added a commit that referenced this issue


          feat(next): update Next.js settings to add draft mode

b9b6de4

Issue #502

JohnAlbin added a commit that referenced this issue


          feat(next-drupal): add draft mode for app router pages

9669b60

Issue #502

JohnAlbin added a commit that referenced this issue


          feat(next-drupal): add draft mode for app router pages

cbfdfed

Issue #502

JohnAlbin added a commit that referenced this issue


          feat(next-drupal): add draft mode for app router pages

cc4d26f

Issue #502

JohnAlbin added a commit that referenced this issue


          feat(next-drupal): add draft mode for app router pages

9b53af3

Issue #502

JohnAlbin added a commit that referenced this issue


          feat(next): update Next.js settings to add draft mode

87e8661

Issue #502

JohnAlbin added a commit that referenced this issue


          feat(next-drupal): add draft mode for app router pages

628591f

Issue #502

JohnAlbin added a commit that referenced this issue


          feat(next): update Next.js settings to add draft mode

31e84ec

Issue #502

JohnAlbin added a commit that referenced this issue


          feat(next-drupal): add draft mode for app router pages

e29d90e

Issue #502

JohnAlbin added a commit that referenced this issue


          feat(next-drupal)!: add draft mode to pages router

18f9a07

Issue #502

BREAKING CHANGE:
The options to the DrupalClient.preview() method were previously ignored. The
options are now passed to the NextApiResponse.setDraftMode() method and their
TypeScript definition have now changed to match the options parameter of the
setDraftMode method.

JohnAlbin added a commit that referenced this issue


          feat(next): update Next.js settings to add draft mode

79b8a53

Issue #502

JohnAlbin added a commit that referenced this issue


          feat(next-drupal): add draft mode for app router pages

e4daeec

Issue #502

JohnAlbin added a commit that referenced this issue


          feat(next-drupal)!: add draft mode to pages router

a11183a

Issue #502

BREAKING CHANGE:
The options to the DrupalClient.preview() method were previously ignored. The
options are now passed to the NextApiResponse.setDraftMode() method and their
TypeScript definition have now changed to match the options parameter of the
setDraftMode method.

JohnAlbin added a commit that referenced this issue


          feat(next): update Next.js settings to add draft mode

03f5736

Issue #502

JohnAlbin added a commit that referenced this issue


          feat(next-drupal): add draft mode for app router pages

423920e

Issue #502

JohnAlbin added a commit that referenced this issue


          feat(next-drupal)!: add draft mode to pages router

20fcb26

Issue #502

BREAKING CHANGE:
The options to the DrupalClient.preview() method were previously ignored. The
options are now passed to the NextApiResponse.setDraftMode() method and their
TypeScript definition have now changed to match the options parameter of the
setDraftMode method.

JohnAlbin mentioned this issue

Add draft mode support #670

Merged

3 tasks

JohnAlbin added a commit that referenced this issue


          feat(next): update Next.js settings to add draft mode

d03b951

Issue #502

JohnAlbin added a commit that referenced this issue


          feat(next-drupal): add draft mode for app router pages

0ff5986

Issue #502

JohnAlbin added a commit that referenced this issue


          feat(next-drupal)!: add draft mode to pages router

1de6fb2

Issue #502

BREAKING CHANGE:
The options to the DrupalClient.preview() method were previously ignored. The
options are now passed to the NextApiResponse.setDraftMode() method and their
TypeScript definition have now changed to match the options parameter of the
setDraftMode method.

JohnAlbin added a commit that referenced this issue


          feat(next): update Next.js settings to add draft mode

06fd733

Issue #502

JohnAlbin added a commit that referenced this issue


          feat(next-drupal): add draft mode for app router pages

0a1fbf9

Issue #502

JohnAlbin added a commit that referenced this issue


          feat(next-drupal)!: add draft mode to pages router

9e4e77d

Issue #502

BREAKING CHANGE:
The options to the DrupalClient.preview() method were previously ignored. The
options are now passed to the NextApiResponse.setDraftMode() method and their
TypeScript definition have now changed to match the options parameter of the
setDraftMode method.

JohnAlbin added a commit that referenced this issue


          feat(next): update Next.js settings to add draft mode

a307486

Issue #502

JohnAlbin added a commit that referenced this issue


          feat(next-drupal): add draft mode for app router pages

0036b73

Issue #502

JohnAlbin added a commit that referenced this issue


          feat(next-drupal)!: add draft mode to pages router

f06e1df

Issue #502

BREAKING CHANGE:
The options to the DrupalClient.preview() method were previously ignored. The
options are now passed to the NextApiResponse.setDraftMode() method and their
TypeScript definition have now changed to match the options parameter of the
setDraftMode method.

JohnAlbin added a commit that referenced this issue


          feat(next-drupal): add draft mode for app router pages

cf88068

Issue #502

JohnAlbin added a commit that referenced this issue


          feat(next-drupal)!: add draft mode to pages router

db5c030

Issue #502

BREAKING CHANGE:
The options to the DrupalClient.preview() method were previously ignored. The
options are now passed to the NextApiResponse.setDraftMode() method and their
TypeScript definition have now changed to match the options parameter of the
setDraftMode method.

JohnAlbin added a commit that referenced this issue


          feat(next-drupal)!: add draft mode to pages router

4a4945f

Issue #502

BREAKING CHANGE:
The options to the DrupalClient.preview() method were previously ignored. The
options are now passed to the NextApiResponse.setDraftMode() method and their
TypeScript definition have now changed to match the options parameter of the
setDraftMode method.

JohnAlbin added a commit that referenced this issue


          feat(next): update Next.js settings to add draft mode

11e108a

Issue #502

JohnAlbin added a commit that referenced this issue


          feat(next-drupal): add draft mode for app router pages

7a62a39

Issue #502

JohnAlbin added a commit that referenced this issue


          feat(next-drupal)!: add draft mode to pages router

a4f8d84

Issue #502

BREAKING CHANGE:
The options to the DrupalClient.preview() method were previously ignored. The
options are now passed to the NextApiResponse.setDraftMode() method and their
TypeScript definition have now changed to match the options parameter of the
setDraftMode method.

Collaborator Author

JohnAlbin commented Feb 20, 2024

Fixed with #670

JohnAlbin closed this as completed

JohnAlbin mentioned this issue

Roadmap for next-drupal 2.0 release #692

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment