Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add draft mode support #670

Merged
merged 6 commits into from
Jan 30, 2024
Merged

Add draft mode support #670

merged 6 commits into from
Jan 30, 2024

Conversation

JohnAlbin
Copy link
Collaborator

This pull request is for:

  • examples/*
  • modules/next
  • packages/next-drupal

GitHub Issue: #502

Describe your changes

  • Adds draft mode for App Router
  • Adds draft mode for Pages Router
  • Adds an example for router migration
  • Updates Drupal module to switch Preview Mode to Draft Mode
  • Drops the no-longer-needed forceIframeSameSiteCookie option

Copy link

vercel bot commented Jan 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
next-drupal ⬜️ Ignored (Inspect) Visit Preview Jan 30, 2024 9:21pm

@JohnAlbin JohnAlbin force-pushed the 502-draft-mode branch 2 times, most recently from f68e212 to 315d517 Compare January 29, 2024 23:05
@JohnAlbin JohnAlbin marked this pull request as ready for review January 30, 2024 00:39
Issue #502

BREAKING CHANGE:
The options to the DrupalClient.preview() method were previously ignored. The
options are now passed to the NextApiResponse.setDraftMode() method and their
TypeScript definition have now changed to match the options parameter of the
setDraftMode method.
BREAKING CHANGE:
The forceIframeSameSiteCookie option to DrupalClient has been removed. The
DrupalClient now automatically makes this change when the Next.js website is
running in development mode (and the change is not needed for production sites).
@JohnAlbin JohnAlbin merged commit 31958b5 into main Jan 30, 2024
12 checks passed
@JohnAlbin JohnAlbin deleted the 502-draft-mode branch January 30, 2024 22:04
@JohnAlbin JohnAlbin mentioned this pull request Mar 8, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants