Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should missingMask == 0 instead of 1? #7

Closed
jiunyen-ching opened this issue Jun 28, 2020 · 2 comments
Closed

Should missingMask == 0 instead of 1? #7

jiunyen-ching opened this issue Jun 28, 2020 · 2 comments

Comments

@jiunyen-ching
Copy link

Hi, under computeNormalsSquareSupport function, I was wondering if we should compare msisingMask to 0 instead of 1? Because the values at the borders and missing depths are 0.

A sample image of the NYU0003_0000.png (rawDepth)
NYU0003_0000_rawDepths

@charlesCXK
Copy link
Owner

Let's see how missingMask is defined:
missingMask = (RD == 0); (in getHHA.py)
So missingMask==1 means this area is missing and its depth value is 0.

@jiunyen-ching
Copy link
Author

Ahh I see! Thanks for pointing it out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants