Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The scopes() function points to a defunct URL, causing downstream issues. #160

Closed
dwh1142 opened this issue Oct 20, 2021 · 5 comments
Closed
Assignees
Labels

Comments

@dwh1142
Copy link

dwh1142 commented Oct 20, 2021

The spotifyr::scopes() function, which spotifyr::get_spotify_authorization_code(), relies on, points to this page: https://developer.spotify.com/documentation/general/guides/scopes/. This url comes back with a 404 Error, and looks like it no longer exists.

I believe it should be pointing here instead: https://developer.spotify.com/documentation/general/guides/authorization/scopes/

Because many other functions are calling spotifyr::get_spotify_authorization_code() for authorization, this is causing all kinds of downstream issues.

See this StackOverflow question:
https://stackoverflow.com/questions/69649706/error-while-trying-to-extract-spotify-data-using-r

@antaldaniel antaldaniel self-assigned this Oct 25, 2021
@antaldaniel antaldaniel added this to the New major CRAN release milestone Oct 25, 2021
@antaldaniel
Copy link
Collaborator

This is indeed an urgency because it will throw out the package from CRAN.

@paulvanleeuwen
Copy link

Could you give an indication when this problem will be solved? Thanks in advance!

@antaldaniel
Copy link
Collaborator

@paulvanleeuwen as soon as somebody sends a well-documented pull-request with the solution.

@apsteinmetz
Copy link

apsteinmetz commented Oct 30, 2021

It's a simple matter of changing to the correct url in utils.r::scopes(). When I do that CMD check passes that function. I am not fluent in github pull requests or I would be happy to do it. As an aside, it seems like relying on a documentation page existing when the package is about API calls seems fraught with peril. Love this package, though!

However, there is another check failure involving a bad URL. I don't know if they are related:
[1] 3

get_category_playlists('party', country = 'BR')
Error in as.character(url) :
cannot coerce type 'closure' to vector of type 'character'
Calls: get_category_playlists ... handle_name -> build_url -> stopifnot -> is.url -> parse_url
Execution halted

@antaldaniel
Copy link
Collaborator

Same as #160 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants