Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bad variable in browse::get_category_playlists() #161

Closed
apsteinmetz opened this issue Oct 30, 2021 · 1 comment
Closed

bad variable in browse::get_category_playlists() #161

apsteinmetz opened this issue Oct 30, 2021 · 1 comment

Comments

@apsteinmetz
Copy link

apsteinmetz commented Oct 30, 2021

Check reveals this:
[1] 3

get_category_playlists('party', country = 'BR')
Error in as.character(url) :
cannot coerce type 'closure' to vector of type 'character'
Calls: get_category_playlists ... handle_name -> build_url -> stopifnot -> is.url -> parse_url
Execution halted

This line:
res <- RETRY('GET', url, query = params, encode = 'json', terminate_on = c(401, 403, 404))
does not reference "url" as a string variable, but the function "url()"

I think "query_url" what is meant
res <- RETRY('GET', query_url, query = params, encode = 'json', terminate_on = c(401, 403, 404))

The function passes check this way.

Originally posted by @apsteinmetz in #160 (comment)

antaldaniel added a commit to antaldaniel/spotifyr that referenced this issue Nov 2, 2021
@antaldaniel
Copy link
Collaborator

@apsteinmetz Thank you very much, very sharp eyes! I went back to this issue many times, and did not spot the obvious error that you did. Included in 2.2.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants