Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsisten results #43

Closed
GoogleCodeExporter opened this issue Mar 15, 2015 · 7 comments
Closed

Inconsisten results #43

GoogleCodeExporter opened this issue Mar 15, 2015 · 7 comments

Comments

@GoogleCodeExporter
Copy link

Here are some ISBN numbers/titles where the results are a bit strange....
Might help in debugging:

Book found by number, title shown, tap on title and then I get an error
book not found: 
034531980x Sentenced to Prism

Book not found by number but title:
00600934719 Stardust
0446356018 Cradle


Wrong result by scan, multiple options by manual entry, wrong one (first in
list) chosen even if right one (second or further down in list) is tapped:
3453009754 Hainish
3435301439 Der Herr des Wüstenplaneten
3453308425 Der Gottkaiser des Wüstenplaneten
345330523x Der Wüstenplanet
Not found at all neither via isbn nor author and title:
0061001082 The Bridge, Ian Banks

Original issue reported on code.google.com by afx...@gmail.com on 9 May 2010 at 11:18

@GoogleCodeExporter
Copy link
Author

The results come from Google Books right now. If something is inconsistent it 
is 
likely due to different revisions of the book (one title, different revisions) 
and 
what is searching/scanning is a different revision. I'll check these out on 
Google 
Books and do some more testing to be sure, but probably not something I can 
"fix" 
(other than to add an enhancement to show multiple revisions on the result 
page, if 
present, or something like that). 

Original comment by charlie....@gmail.com on 10 May 2010 at 1:26

@GoogleCodeExporter
Copy link
Author

Of the three groups the last one is the most problematic one.
Bookworm already finds the right one, but then takes the first one from the 
presented
list, no matter which one I choose.
Which is especially crazy in case of 3453009754 Hainish if you look at the title
found first....


Original comment by afx...@gmail.com on 10 May 2010 at 1:37

@GoogleCodeExporter
Copy link
Author

Original comment by charlie....@gmail.com on 11 May 2010 at 5:25

  • Changed state: Accepted

@GoogleCodeExporter
Copy link
Author

I added some more info to the manual search web results list tonight (will be 
released soon, 1.0.7).  This now shows title and the author(s). It doesn't show 
the 
ISBN, but it could?  

Reason I did this is so users can see more about the book before clicking it in 
the 
manual web search results list. 

Also, I now see what you mean by this bug report, I didn't understand it 
before. 

I can recreate with the following steps: 

1. Search the web for "3453009754"
2. Results page shows 2 results - 1. Adolf Hitler Mein Kampf, 2. Ursula Le Guin 
Hainish. 
3. Click on Hainish
4. Add book page comes up with Mein Kampf.

DOH! 

Looking into this tonight . . . 

Original comment by charlie....@gmail.com on 15 May 2010 at 1:49

@GoogleCodeExporter
Copy link
Author

Issue 30 has been merged into this issue.

Original comment by charlie....@gmail.com on 15 May 2010 at 1:50

@GoogleCodeExporter
Copy link
Author

Actually, this seems to be happening because the Google Books search itself 
comes 
back with multiple entries for the ISBN, and the search result page expects ONE 
per 
ISBN and just selects the first one. 

For example, checkit: http://books.google.com/books/feeds/volumes?
as_pt=BOOKS&q=isbn:3453009754

Need to make search results page smarter. If more than one result is there per 
ISBN, 
go past the ISBN and use the title. Kind of a bitch, but that's how ISBNs are I 
guess.

Original comment by charlie....@gmail.com on 15 May 2010 at 1:56

@GoogleCodeExporter
Copy link
Author

Fixed in SVN, and selecting a result should be much faster now too, no longer 
makes 
another HTTP call with the ISBN on the display result page, it just uses the 
result 
selected on the list page (should have done this all along, much more efficient 
-- and 
solves the select when more than one book have same ISBN). 

Original comment by charlie....@gmail.com on 15 May 2010 at 2:19

  • Changed state: Fixed
  • Added labels: 1.0.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant