Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onion Skinning is not very intuitive #71

Closed
rioforce opened this issue Oct 31, 2015 · 8 comments
Closed

Onion Skinning is not very intuitive #71

rioforce opened this issue Oct 31, 2015 · 8 comments
Labels
feature New or enhanced functionality for users

Comments

@rioforce
Copy link
Contributor

While this is mainly my issue, since I redesigned the entire Onion Skinning slider, I thought I'd bring it up so we can discuss it. Basically, as it is, the onion skinning slider isn't very easy to understand. It is in the middle, and you can drag it up and down to change the onion skinning factor, but it only takes effect if the Onion Skinning button is enabled. The button and slider act awkwardly together, and it's not really easy to understand what each is at first glance.

So, I am thinking we need to find a way to get rid of the button and use the slider exclusively. One way to do this is to make the onion slider be at the bottom of the slider by default, and when you drag it up and down, it adjusts the opacity. This removes the need for a separate onion skinning button, but it makes the slider look off-balance with everything, since the circle isn't in the middle.

Another way to do it is to make the left and right portions of the slider do different things. It works like this in Dragonframe:

  • Drag to the right: Onion skins last frame taken with live preview. If you select another frame, it doesn't show any live preview or onion skinning.
  • Drag to the left: Onion skins last frame taken with live preview if on live mode. If you select another frame in the reel, it'll use that for onion skinning instead.

We don't have to do it like this, I'm just unsure what we need to do. Eliminating a need for a separate button would help a lot.
What do you guys think?

@rioforce rioforce mentioned this issue Oct 31, 2015
@trevor-sprague
Copy link

I agree that the button and slider is confusing, especially when using the program for the first time. I personally like the second proposal, as it seems like a more intuitive and versatile solution.

@charlielee
Copy link
Owner

Working towards a solution where the slider does different things based on if it is dragged left or right seems good. Although, as I mentioned in your pull request, the playback code must be sorted out first so this can be accommodated.

We could partially implement this by removing the toggle button and having the last frame onion skin when the slider is dragged to the right. For now, moving the slider left of centre will do nothing.

@charlielee charlielee added the feature New or enhanced functionality for users label Nov 3, 2015
@charlielee charlielee modified the milestone: v0.8.x Dec 13, 2015
@charlielee
Copy link
Owner

The keyframe system I'm currently working on in #116 could allow this to be implemented.

@charlielee
Copy link
Owner

If my keyframe system in #122 is implemented this feature could work so that sliding to the left shows the current keyframe as the onion skinning frame and sliding to the right shows the last captured frame.

@le717
Copy link
Contributor

le717 commented Mar 4, 2016

If you think you can implement this once keyframes lands, then I'll go ahead and move this to 0.7.x.

@le717 le717 modified the milestones: v0.7.x, v0.8.x Mar 4, 2016
@charlielee charlielee mentioned this issue Mar 5, 2016
32 tasks
@charlielee charlielee self-assigned this Mar 30, 2016
le717 added a commit that referenced this issue Dec 19, 2016
@le717
Copy link
Contributor

le717 commented Dec 20, 2016

@Robotic-Animations @rioforce You'll be happy to know this is currently in development at #122. 😃

@charlielee
Copy link
Owner

This (along with #116) was implemented in PR #122, however I recently closed that PR unmerged because it was stale for over 2 years. This is certainly a feature to consider implementing again in the future, taking inspiration from the ideas in #122.

@charlielee
Copy link
Owner

I've created a new issue for enabling different behaviour when the slider is moved to the left. #320 Who knew I'd still be working on Boats Animator 6 years on! 😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New or enhanced functionality for users
Projects
None yet
Development

No branches or pull requests

4 participants