-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compressed UI #73
Compressed UI #73
Conversation
Not sure if the color of the button is good as a brighter color, maybe it should be dark gray again, but either way, I fixed the size of the button.
Also added a placeholder grid overlay button
Makes the video preview larger, which is key to animation
Perhaps the onion skinning could be made more initiative by only having the slider bar appear when it the toggle button is activated, this would make it clear that the toggle button was related to it. Although this probably won't work so well when other things are added to the bottom toolbar. The method you suggest in #71 to make the onion skinning slider more Dragonframe like would certainly make it much more powerful, although it is probably too complicated to implement until the frames on the frame reel are clickable. Correct me if I'm wrong, but I don't think it is very often that frames other than the last one captured are used for onion skinning. I think the delete buttons on the frame reel should be removed too. When the ability to click on individual frames for a larger preview is implemented it would be great for the delete icon to show up in preview mode. Perhaps it could swap positions with the undo button so that the undo button only shows in capture mode and the delete button only shows in playback mode. Also I don't know about the capture button being yellow. It might grow on me but I think it would be fine if it was white. I need to catch up on some sleep now, so I shall check out your branch and most likely merge in the morning. |
I shall merge this. I've suggested what should be done in the short term in regards to onion skinning in #71 |
In this revision, I shrunk down the below-the-video options and framereel. This adds much more room to the video preview, which is vital to animating. I also added the grid overlay button and the delete frame button.
IMO, the delete frame button on each frame in the framereel should go away, because it seems too easy to accidentally click. The main delete button would work better, because ideally, when you delete a frame, it automatically previews the next frame, thus, if someone was deleting many frames in a row, they wouldn't need to move their mouse, just click delete over and over again.
As you can see, I'm still struggling with the onion skin button. I made an issue for that (#71).
There are still issues with it, as usual, but it's fairly solid.
What do you think?