Bring pycodestyle rules into full compatibility (on SciPy) #4472

charliermarsh · 2023-05-17T14:48:15Z

Summary

This PR contains a handful of bug fixes that were necessary to get our pycodestyle rules to output identical diagnostics to pycodestyle itself when run on the SciPy repo (which I'm using as "a large, diverse codebase that does not use Black and includes some known violations").

For posterity, here's the script I used to diff against SciPy, which could in theory be applied to any other project: https://gist.github.com/charliermarsh/3f2855f33960c92306c91d003b6237dc.

charliermarsh · 2023-05-17T14:48:57Z

I'm going to carve a couple of these out into separate PRs, so draft for now.

github-actions · 2023-05-17T14:56:36Z

PR Check Results

Ecosystem

✅ ecosystem check detected no changes.

Benchmark

Linux

group                                      main                                   pr
-----                                      ----                                   --
linter/all-rules/large/dataset.py          1.02     14.8±0.11ms     2.8 MB/sec    1.00     14.4±0.09ms     2.8 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.02      3.5±0.03ms     4.7 MB/sec    1.00      3.5±0.01ms     4.8 MB/sec
linter/all-rules/numpy/globals.py          1.00    428.5±1.49µs     6.9 MB/sec    1.00    428.3±1.25µs     6.9 MB/sec
linter/all-rules/pydantic/types.py         1.01      6.0±0.05ms     4.2 MB/sec    1.00      5.9±0.05ms     4.3 MB/sec
linter/default-rules/large/dataset.py      1.03      7.0±0.10ms     5.8 MB/sec    1.00      6.7±0.03ms     6.0 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.01   1479.2±2.43µs    11.3 MB/sec    1.00   1460.6±2.32µs    11.4 MB/sec
linter/default-rules/numpy/globals.py      1.00    164.2±0.76µs    18.0 MB/sec    1.00    163.6±3.36µs    18.0 MB/sec
linter/default-rules/pydantic/types.py     1.01      3.1±0.01ms     8.3 MB/sec    1.00      3.1±0.01ms     8.3 MB/sec
parser/large/dataset.py                    1.01      5.5±0.01ms     7.4 MB/sec    1.00      5.4±0.01ms     7.5 MB/sec
parser/numpy/ctypeslib.py                  1.00   1067.9±0.76µs    15.6 MB/sec    1.00   1063.2±1.82µs    15.7 MB/sec
parser/numpy/globals.py                    1.01    109.8±0.34µs    26.9 MB/sec    1.00    108.5±0.21µs    27.2 MB/sec
parser/pydantic/types.py                   1.01      2.3±0.00ms    11.0 MB/sec    1.00      2.3±0.00ms    11.1 MB/sec

Windows

group                                      main                                    pr
-----                                      ----                                    --
linter/all-rules/large/dataset.py          1.01     20.3±0.57ms  2047.5 KB/sec     1.00     20.2±0.59ms     2.0 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.01      5.2±0.18ms     3.2 MB/sec     1.00      5.2±0.20ms     3.2 MB/sec
linter/all-rules/numpy/globals.py          1.00   620.1±30.62µs     4.8 MB/sec     1.00   618.0±27.92µs     4.8 MB/sec
linter/all-rules/pydantic/types.py         1.01      8.6±0.31ms     3.0 MB/sec     1.00      8.5±0.26ms     3.0 MB/sec
linter/default-rules/large/dataset.py      1.00     10.2±0.36ms     4.0 MB/sec     1.00     10.2±0.33ms     4.0 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00      2.1±0.08ms     7.8 MB/sec     1.00      2.1±0.11ms     7.8 MB/sec
linter/default-rules/numpy/globals.py      1.00   256.1±13.60µs    11.5 MB/sec     1.00   256.3±11.90µs    11.5 MB/sec
linter/default-rules/pydantic/types.py     1.00      4.5±0.14ms     5.7 MB/sec     1.00      4.5±0.17ms     5.7 MB/sec
parser/large/dataset.py                    1.03      8.5±0.21ms     4.8 MB/sec     1.00      8.3±0.16ms     4.9 MB/sec
parser/numpy/ctypeslib.py                  1.02  1645.0±125.33µs    10.1 MB/sec    1.00  1613.4±63.32µs    10.3 MB/sec
parser/numpy/globals.py                    1.02    168.1±8.40µs    17.6 MB/sec     1.00   164.8±17.97µs    17.9 MB/sec
parser/pydantic/types.py                   1.04      3.7±0.17ms     6.9 MB/sec     1.00      3.6±0.12ms     7.2 MB/sec

crates/ruff/src/checkers/logical_lines.rs

crates/ruff/src/rules/pycodestyle/rules/logical_lines/missing_whitespace.rs

crates/ruff_python_ast/src/token_kind.rs

crates/ruff/src/rules/pycodestyle/rules/logical_lines/mod.rs

crates/ruff/src/checkers/logical_lines.rs

crates/ruff/src/rules/pycodestyle/rules/logical_lines/mod.rs

crates/ruff_python_ast/src/token_kind.rs

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ruff](https://togithub.com/charliermarsh/ruff) ([changelog](https://togithub.com/charliermarsh/ruff/releases)) | `^0.0.267` -> `^0.0.269` | [![age](https://badges.renovateapi.com/packages/pypi/ruff/0.0.269/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/ruff/0.0.269/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/ruff/0.0.269/compatibility-slim/0.0.267)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/ruff/0.0.269/confidence-slim/0.0.267)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>charliermarsh/ruff</summary> ### [`v0.0.269`](https://togithub.com/charliermarsh/ruff/releases/tag/v0.0.269) [Compare Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.267...v0.0.269)  #### What's Changed (This is a rerelease of `v0.0.268`, which didn't make it to PyPI due to user error. As such, the release notes are copied below.) ##### `pycodestyle` This release includes optimized implementations of a large portion of `pycodestyle`, for those that use Ruff without an autoformatter. In this initial release, the rules are being introduced under a "nursery" flag, which requires that users explicitly select them (e.g., `select = ["E111"]`); in other words, these rules are not yet enabled via `select = ["E"]`. If you're interested in testing the `pycodestyle` rules, you can enable them via: ```toml select = [ "E111", "E112", "E113", "E114", "E115", "E116", "E117", "E201", "E202", "E203", "E211", "E221", "E222", "E223", "E224", "E225", "E226", "E227", "E228", "E231", "E251", "E252", "E261", "E262", "E265", "E266", "E271", "E272", "E273", "E274", "E275", ] ``` These rules will be included as part of the `E` category in a future release. ##### Breaking Changes - \[`pyupgrade`] Remove `keep-runtime-typing` setting by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4427 ##### Rules - \[`pylint`] Add `duplicate-bases` rule by [@alonme](https://togithub.com/alonme) in [astral-sh/ruff#4411 - \[`pylint`] Fix `PLW3301` auto-fix with generators by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#4412 - \[`flake8-async`] Implement flake8-async plugin by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#4432 - \[`pyupgrade`] Enable automatic rewrites of `typing.Deque` and `typing.DefaultDict` by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4420 - \[`flake8-pyi`] Implement `unannotated-assignment-in-stub` (`PY052`) by [@sladyn98](https://togithub.com/sladyn98) in [astral-sh/ruff#4293 - \[`tryceratops`] Implement TRY302 - `raise` after `except` by [@john-h-k](https://togithub.com/john-h-k) in [astral-sh/ruff#4461 - \[`flake8-bandit`] Improve SQL injection detection logic (`S608`) by [@scop](https://togithub.com/scop) in [astral-sh/ruff#4499 - \[`flake8-todos`] Implement `flake8_todos` by [@evanrittenhouse](https://togithub.com/evanrittenhouse) in [astral-sh/ruff#3921 - \[`flake8-future-annotations`] Implement `flake8-future-annotations` FA100 by [@TylerYep](https://togithub.com/TylerYep) in [astral-sh/ruff#3979 - Enable `pycodestyle` rules by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3689 - Enable `pycodestyle` rules under new "nursery" category by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4407 ##### Settings - Merge subsettings when extending configurations by [@bendoerry](https://togithub.com/bendoerry) in [astral-sh/ruff#4431 ##### Bug Fixes - Extend multi-line noqa directives to start-of-line by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4490 - Fix scoping of comprehensions within classes by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4494 - Enable autofix for split-assertions at top level by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4405 - Ignore ANN401 for overridden methods by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#4409 - Fix `RUF010` autofix within f-strings by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#4423 - Update C419 to be a suggested fix by [@madkinsz](https://togithub.com/madkinsz) in [astral-sh/ruff#4424 - Fix expected-indentation errors with end-of-line comments by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4438 - Emit non-logical newlines for "empty" lines by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4444 - Avoid emitting empty logical lines by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4452 - Avoid flagging missing whitespace for decorators by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4454 - Remove special-casing for whitespace-around-@ by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4458 - Avoid triggering `pd#at` and friends on non-subscripts by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4474 - Include precise tokens for extraneous-whitespace diagnostics by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4471 - Allow shebang comments at start-of-file by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4473 - Bring pycodestyle rules into full compatibility (on SciPy) by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4472 - Invert quote-style when generating code within f-strings by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4487 - Fix COM812 false positive in string subscript by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#4493 - Overhaul sdist handling by [@konstin](https://togithub.com/konstin) in [astral-sh/ruff#4439 #### New Contributors - [@TylerYep](https://togithub.com/TylerYep) made their first contribution in [astral-sh/ruff#3979 - [@yanksyoon](https://togithub.com/yanksyoon) made their first contribution in [astral-sh/ruff#4428 - [@bendoerry](https://togithub.com/bendoerry) made their first contribution in [astral-sh/ruff#4431 - [@qdegraaf](https://togithub.com/qdegraaf) made their first contribution in [astral-sh/ruff#4432 - [@jameslamb](https://togithub.com/jameslamb) made their first contribution in [astral-sh/ruff#4446 - [@john-h-k](https://togithub.com/john-h-k) made their first contribution in [astral-sh/ruff#4461 **Full Changelog**: astral-sh/ruff@v0.0.267...v0.0.269 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/ixm-one/pytest-cmake-presets).  Signed-off-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ruff](https://togithub.com/charliermarsh/ruff) ([changelog](https://togithub.com/charliermarsh/ruff/releases)) | `==0.0.267` -> `==0.0.269` | [![age](https://badges.renovateapi.com/packages/pypi/ruff/0.0.269/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/ruff/0.0.269/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/ruff/0.0.269/compatibility-slim/0.0.267)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/ruff/0.0.269/confidence-slim/0.0.267)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>charliermarsh/ruff</summary> ### [`v0.0.269`](https://togithub.com/charliermarsh/ruff/releases/tag/v0.0.269) [Compare Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.267...v0.0.269)  #### What's Changed (This is a rerelease of `v0.0.268`, which didn't make it to PyPI due to user error. As such, the release notes are copied below.) ##### `pycodestyle` This release includes optimized implementations of a large portion of `pycodestyle`, for those that use Ruff without an autoformatter. In this initial release, the rules are being introduced under a "nursery" flag, which requires that users explicitly select them (e.g., `select = ["E111"]`); in other words, these rules are not yet enabled via `select = ["E"]`. If you're interested in testing the `pycodestyle` rules, you can enable them via: ```toml select = [ "E111", "E112", "E113", "E114", "E115", "E116", "E117", "E201", "E202", "E203", "E211", "E221", "E222", "E223", "E224", "E225", "E226", "E227", "E228", "E231", "E251", "E252", "E261", "E262", "E265", "E266", "E271", "E272", "E273", "E274", "E275", ] ``` These rules will be included as part of the `E` category in a future release. ##### Breaking Changes - \[`pyupgrade`] Remove `keep-runtime-typing` setting by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4427 ##### Rules - \[`pylint`] Add `duplicate-bases` rule by [@alonme](https://togithub.com/alonme) in [astral-sh/ruff#4411 - \[`pylint`] Fix `PLW3301` auto-fix with generators by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#4412 - \[`flake8-async`] Implement flake8-async plugin by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#4432 - \[`pyupgrade`] Enable automatic rewrites of `typing.Deque` and `typing.DefaultDict` by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4420 - \[`flake8-pyi`] Implement `unannotated-assignment-in-stub` (`PY052`) by [@sladyn98](https://togithub.com/sladyn98) in [astral-sh/ruff#4293 - \[`tryceratops`] Implement TRY302 - `raise` after `except` by [@john-h-k](https://togithub.com/john-h-k) in [astral-sh/ruff#4461 - \[`flake8-bandit`] Improve SQL injection detection logic (`S608`) by [@scop](https://togithub.com/scop) in [astral-sh/ruff#4499 - \[`flake8-todos`] Implement `flake8_todos` by [@evanrittenhouse](https://togithub.com/evanrittenhouse) in [astral-sh/ruff#3921 - \[`flake8-future-annotations`] Implement `flake8-future-annotations` FA100 by [@TylerYep](https://togithub.com/TylerYep) in [astral-sh/ruff#3979 - Enable `pycodestyle` rules by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3689 - Enable `pycodestyle` rules under new "nursery" category by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4407 ##### Settings - Merge subsettings when extending configurations by [@bendoerry](https://togithub.com/bendoerry) in [astral-sh/ruff#4431 ##### Bug Fixes - Extend multi-line noqa directives to start-of-line by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4490 - Fix scoping of comprehensions within classes by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4494 - Enable autofix for split-assertions at top level by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4405 - Ignore ANN401 for overridden methods by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#4409 - Fix `RUF010` autofix within f-strings by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#4423 - Update C419 to be a suggested fix by [@madkinsz](https://togithub.com/madkinsz) in [astral-sh/ruff#4424 - Fix expected-indentation errors with end-of-line comments by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4438 - Emit non-logical newlines for "empty" lines by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4444 - Avoid emitting empty logical lines by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4452 - Avoid flagging missing whitespace for decorators by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4454 - Remove special-casing for whitespace-around-@ by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4458 - Avoid triggering `pd#at` and friends on non-subscripts by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4474 - Include precise tokens for extraneous-whitespace diagnostics by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4471 - Allow shebang comments at start-of-file by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4473 - Bring pycodestyle rules into full compatibility (on SciPy) by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4472 - Invert quote-style when generating code within f-strings by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4487 - Fix COM812 false positive in string subscript by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#4493 - Overhaul sdist handling by [@konstin](https://togithub.com/konstin) in [astral-sh/ruff#4439 #### New Contributors - [@TylerYep](https://togithub.com/TylerYep) made their first contribution in [astral-sh/ruff#3979 - [@yanksyoon](https://togithub.com/yanksyoon) made their first contribution in [astral-sh/ruff#4428 - [@bendoerry](https://togithub.com/bendoerry) made their first contribution in [astral-sh/ruff#4431 - [@qdegraaf](https://togithub.com/qdegraaf) made their first contribution in [astral-sh/ruff#4432 - [@jameslamb](https://togithub.com/jameslamb) made their first contribution in [astral-sh/ruff#4446 - [@john-h-k](https://togithub.com/john-h-k) made their first contribution in [astral-sh/ruff#4461 **Full Changelog**: astral-sh/ruff@v0.0.267...v0.0.269 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/allenporter/pyrainbird).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ruff](https://togithub.com/charliermarsh/ruff) ([changelog](https://togithub.com/charliermarsh/ruff/releases)) | `==0.0.267` -> `==0.0.269` | [![age](https://badges.renovateapi.com/packages/pypi/ruff/0.0.269/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/ruff/0.0.269/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/ruff/0.0.269/compatibility-slim/0.0.267)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/ruff/0.0.269/confidence-slim/0.0.267)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>charliermarsh/ruff</summary> ### [`v0.0.269`](https://togithub.com/charliermarsh/ruff/releases/tag/v0.0.269) [Compare Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.267...v0.0.269)  #### What's Changed (This is a rerelease of `v0.0.268`, which didn't make it to PyPI due to user error. As such, the release notes are copied below.) ##### `pycodestyle` This release includes optimized implementations of a large portion of `pycodestyle`, for those that use Ruff without an autoformatter. In this initial release, the rules are being introduced under a "nursery" flag, which requires that users explicitly select them (e.g., `select = ["E111"]`); in other words, these rules are not yet enabled via `select = ["E"]`. If you're interested in testing the `pycodestyle` rules, you can enable them via: ```toml select = [ "E111", "E112", "E113", "E114", "E115", "E116", "E117", "E201", "E202", "E203", "E211", "E221", "E222", "E223", "E224", "E225", "E226", "E227", "E228", "E231", "E251", "E252", "E261", "E262", "E265", "E266", "E271", "E272", "E273", "E274", "E275", ] ``` These rules will be included as part of the `E` category in a future release. ##### Breaking Changes - \[`pyupgrade`] Remove `keep-runtime-typing` setting by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4427 ##### Rules - \[`pylint`] Add `duplicate-bases` rule by [@alonme](https://togithub.com/alonme) in [astral-sh/ruff#4411 - \[`pylint`] Fix `PLW3301` auto-fix with generators by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#4412 - \[`flake8-async`] Implement flake8-async plugin by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#4432 - \[`pyupgrade`] Enable automatic rewrites of `typing.Deque` and `typing.DefaultDict` by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4420 - \[`flake8-pyi`] Implement `unannotated-assignment-in-stub` (`PY052`) by [@sladyn98](https://togithub.com/sladyn98) in [astral-sh/ruff#4293 - \[`tryceratops`] Implement TRY302 - `raise` after `except` by [@john-h-k](https://togithub.com/john-h-k) in [astral-sh/ruff#4461 - \[`flake8-bandit`] Improve SQL injection detection logic (`S608`) by [@scop](https://togithub.com/scop) in [astral-sh/ruff#4499 - \[`flake8-todos`] Implement `flake8_todos` by [@evanrittenhouse](https://togithub.com/evanrittenhouse) in [astral-sh/ruff#3921 - \[`flake8-future-annotations`] Implement `flake8-future-annotations` FA100 by [@TylerYep](https://togithub.com/TylerYep) in [astral-sh/ruff#3979 - Enable `pycodestyle` rules by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3689 - Enable `pycodestyle` rules under new "nursery" category by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4407 ##### Settings - Merge subsettings when extending configurations by [@bendoerry](https://togithub.com/bendoerry) in [astral-sh/ruff#4431 ##### Bug Fixes - Extend multi-line noqa directives to start-of-line by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4490 - Fix scoping of comprehensions within classes by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4494 - Enable autofix for split-assertions at top level by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4405 - Ignore ANN401 for overridden methods by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#4409 - Fix `RUF010` autofix within f-strings by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#4423 - Update C419 to be a suggested fix by [@madkinsz](https://togithub.com/madkinsz) in [astral-sh/ruff#4424 - Fix expected-indentation errors with end-of-line comments by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4438 - Emit non-logical newlines for "empty" lines by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4444 - Avoid emitting empty logical lines by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4452 - Avoid flagging missing whitespace for decorators by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4454 - Remove special-casing for whitespace-around-@ by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4458 - Avoid triggering `pd#at` and friends on non-subscripts by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4474 - Include precise tokens for extraneous-whitespace diagnostics by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4471 - Allow shebang comments at start-of-file by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4473 - Bring pycodestyle rules into full compatibility (on SciPy) by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4472 - Invert quote-style when generating code within f-strings by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4487 - Fix COM812 false positive in string subscript by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#4493 - Overhaul sdist handling by [@konstin](https://togithub.com/konstin) in [astral-sh/ruff#4439 #### New Contributors - [@TylerYep](https://togithub.com/TylerYep) made their first contribution in [astral-sh/ruff#3979 - [@yanksyoon](https://togithub.com/yanksyoon) made their first contribution in [astral-sh/ruff#4428 - [@bendoerry](https://togithub.com/bendoerry) made their first contribution in [astral-sh/ruff#4431 - [@qdegraaf](https://togithub.com/qdegraaf) made their first contribution in [astral-sh/ruff#4432 - [@jameslamb](https://togithub.com/jameslamb) made their first contribution in [astral-sh/ruff#4446 - [@john-h-k](https://togithub.com/john-h-k) made their first contribution in [astral-sh/ruff#4461 **Full Changelog**: astral-sh/ruff@v0.0.267...v0.0.269 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/allenporter/flux-local).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

charliermarsh changed the base branch from main to charlie/bracket May 17, 2023 14:48

charliermarsh force-pushed the charlie/pycodestyle branch from 44e9306 to 093e534 Compare May 17, 2023 14:57

charliermarsh changed the base branch from charlie/bracket to charlie/shebang May 17, 2023 14:57

charliermarsh marked this pull request as ready for review May 17, 2023 14:57

charliermarsh requested a review from MichaReiser May 17, 2023 14:57