Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to specify huh theme #595

Closed
taismassaro opened this issue May 28, 2024 · 3 comments
Closed

Ability to specify huh theme #595

taismassaro opened this issue May 28, 2024 · 3 comments

Comments

@taismassaro
Copy link

taismassaro commented May 28, 2024

Is your feature request related to a problem? Please describe.
I've seen some gum commands are passing the Charm theme directly to huh (e.g. gum confirm) and there is no option to change that (e.g. changing the color of gum confirm "buttons")

Describe the solution you'd like
I would like to either have a flag in gum confirm to be able to pass a background to the selected option, or, ideally, to be able to choose the huh theme in my commands.

Describe alternatives you've considered
I haven't found an alternative to changing the background color of the gum confirm selected option.

Additional context
https://github.com/charmbracelet/gum/blob/main/confirm/command.go#L13
image

@cloudyparts
Copy link

+1 to this request.

I'd like to override the style of input placeholder to make it a brighter. I may be wrong but allowing for theme selection might help here.

gum input --placeholder="$(gum style --foreground="#888888" "placeholder")"
> [38;2;136;136;136mplaceholder

@maaslalani
Copy link
Contributor

Describe alternatives you've considered I haven't found an alternative to changing the background color of the gum confirm selected option.

Hi! This could definitely be documented better but generally when you can specify the foreground of an element you can also specify the background of it.

gum confirm --selected.background="99"

@meowgorithm
Copy link
Member

Hey, everyone. Closing this one for now as I believe --selected.background sorts this one out, but @taismassaro let us know if not.

With regard to Huh themes, because Huh isn't applied to Gum commands across the board (for example, gum table falls outside the realm of Huh) I don't think exposing Huh's theming settings make sense here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants