Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shifters ignoring ISidedInventory #46

Closed
oitsjustjose opened this issue Jan 26, 2016 · 6 comments
Closed

Shifters ignoring ISidedInventory #46

oitsjustjose opened this issue Jan 26, 2016 · 6 comments

Comments

@oitsjustjose
Copy link

I haven't changed any of my code in CrissCross regarding the new Capabilities set, but ISided shouldn't still be ignored if you ask me - lots of mods will take quite a while to implement Capabilities I'd bet. Any chance you can continue to support both of them simultaneously? I'm going to work CrissCross onto the Capabilities API now.

@asiekierka
Copy link
Member

I'm pretty sure I coded them in a manner which makes ISidedInventory not
ignored. Could you give me a test case?

2016-01-26 15:30 GMT+01:00 oitsjustjose notifications@github.com:

I haven't changed any of my code in CrissCross regarding the new
Capabilities set, but ISided shouldn't still be ignored if you ask me -
lots of mods will take quite a while to implement Capabilities I'd bet Any
chance you can continue to support both of them simultaneously? I'm going
to work CrissCross onto the Capabilities API now


Reply to this email directly or view it on GitHub
#46.

@oitsjustjose
Copy link
Author

Here you go - this doesn't happen with Vanilla Furnaces, but happens with my Tiles and the Evolved Furnace from the Alt-F4 Mod.

@oitsjustjose
Copy link
Author

Okay - it's not your fault, this interaction also occurs with Vanilla Hoppers. I guess Forge needs to be the one still considering ISidedness? Regardless, I've already added Capabilities abilities to CrissCross, so it's good to go. Closing this because it isn't your fault :)

@asiekierka
Copy link
Member

I added code to explicitly support ISidedInventories. If they are not being
supported it's well my fault.

2016-01-26 22:18 GMT+01:00 oitsjustjose notifications@github.com:

Okay - it's not your fault, this interaction also occurs with Vanilla
Hoppers. I guess Forge needs to be the one still considering ISidedness?
Regardless, I've already added Capabilities abilities to CrissCross, so
it's good to go. Closing this because it isn't your fault :)


Reply to this email directly or view it on GitHub
#46 (comment)
.

@asiekierka asiekierka reopened this Jan 26, 2016
@oitsjustjose
Copy link
Author

Oh.
Kthen.

@asiekierka asiekierka reopened this Mar 6, 2016
@asiekierka
Copy link
Member

Probably won't matter much on 1.9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants