Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor login form to use react hooks #93

Closed

Conversation

damianstasik
Copy link
Contributor

Another try at refactoring the remaining components to use hooks as part of the #58.

  • Moved social sign-in component inside the render function, no need for the expensive recreation during re-renders
  • Added state hooks for state properties that were uninitialized in the class version

Copy link
Member

@razvanilin razvanilin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

It does not work as intended, though. Same issues as #68 #68 (review)

Please always test the changes on a vital component such as the Login form

@razvanilin
Copy link
Member

Already refactored, closing

@razvanilin razvanilin closed this Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants