remove unnecessary extra init steps #3818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonbrunel
reviewed
Jan 22, 2017
| @@ -124,10 +124,7 @@ module.exports = function(Chart) { | |||
| // Make sure controllers are built first so that each dataset is bound to an axis before the scales | |||
There was a problem hiding this comment.
We might want to cleanup that comment as well ;)
simonbrunel
reviewed
Jan 22, 2017
| me.buildScales(); | ||
| me.updateLayout(); |
There was a problem hiding this comment.
The updateLayout() definition method should also be removed, seems only called from that line.
etimberg
force-pushed
the
improve-init
branch
from
602030b
to
bb2218c
Compare
|
@simonbrunel updated per your comments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the changes to
updateto update configs, these steps are no longer needed as part of the chart initialization sinceupdatewill take care of it. We still need to build scales though, since they are needed inafterInitandupdatecurrently cannot update axes.