Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iss3917 #3958

Closed
wants to merge 43 commits into from
Closed

iss3917 #3958

wants to merge 43 commits into from

Commits on Feb 26, 2017

  1. iss3917

    roicos committed Feb 26, 2017
    Configuration menu
    Copy the full SHA
    ddfee60 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2017

  1. Configuration menu
    Copy the full SHA
    2d63d8a View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2017

  1. Configuration menu
    Copy the full SHA
    7d38cbf View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    dd52e16 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2017

  1. Configuration menu
    Copy the full SHA
    95724e4 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2017

  1. -

    roicos committed Aug 21, 2017
    Configuration menu
    Copy the full SHA
    33298c2 View commit details
    Browse the repository at this point in the history
  2. -

    roicos committed Aug 21, 2017
    Configuration menu
    Copy the full SHA
    fb04dd3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0185146 View commit details
    Browse the repository at this point in the history
  4. Layout service supports a new order setting to configure how boxes ar…

    …e ordered on left and right edges
    etimberg authored and roicos committed Aug 21, 2017
    Configuration menu
    Copy the full SHA
    b65c5c7 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    95576d7 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    65a513f View commit details
    Browse the repository at this point in the history
  7. Handle incoming model values on element transition

    If a value is set on the model after `pivot()` has been called, the view wasn't initialized and the animation started from 0. Now, `_start` and incomplete `_view` are initialized to the model value during the transition (no initial implicit transition).
    
    Also remove exception handling when animating a string (color), which is faster when string are not valid colors (e.g. tooltip position). It requires to update `chartjs-color` to version 2.1.0.
    simonbrunel authored and roicos committed Aug 21, 2017
    Configuration menu
    Copy the full SHA
    95e8898 View commit details
    Browse the repository at this point in the history
  8. Flatten animation object and fix callbacks

    Animation callbacks now receives `animationObject` directly with a reference on the associated chart (`animation.chart`), which deprecates `animation.animationObject` and `animation.chartInstance`. Also fix missing `onComplete` animation argument and make sure that an animation object is passed even when animations are disabled.
    simonbrunel authored and roicos committed Aug 21, 2017
    Configuration menu
    Copy the full SHA
    12065d8 View commit details
    Browse the repository at this point in the history
  9. Split radial scale lineArc setting into a combination of existing and…

    … new settings.
    
    gridLines.circular is a new option that toggles circular lines. This allows radar charts with circular lines chartjs#3082
    pointLabels.display is a new option that toggles the display of point labels.
    The existing angleLines.display is used with the new pointLabels.display setting is used to trigger the radar like settings.
    This required changing the default polar area config.
    etimberg authored and roicos committed Aug 21, 2017
    Configuration menu
    Copy the full SHA
    9a83752 View commit details
    Browse the repository at this point in the history
  10. Added a maxBarThickness setting for bar charts xAxis (chartjs#3963)

    Added a `maxBarThickness` setting for bar charts xAxis
    seven7seven authored and roicos committed Aug 21, 2017
    Configuration menu
    Copy the full SHA
    4ca0d73 View commit details
    Browse the repository at this point in the history
  11. Fix shorthand legend: false and title: false

    Prevent attempt to remove the legend or title layout items if they haven't been created but also check if the item to remove is registered with the layout manager to avoid removing the wrong box `splice(-1, 1)`. Add ids to the legend and title plugins to allow to fully disable them (`options: {plugins: {legend: false, title: false}}`).
    simonbrunel authored and roicos committed Aug 21, 2017
    Configuration menu
    Copy the full SHA
    6486f5c View commit details
    Browse the repository at this point in the history
  12. Cleanup and upgrade unit tests environment

    `karma.conf.ci.js` has been merged into `karma.conf.js` for local testing consistency: `gulp unittestWatch` has been replaced by `gulp unittest --watch` and thus use exactly the same config file. Upgrade to latest jasmine and karma packages and remove deprecated `gulp-karma` dependency (directly use `karma.Server` in gulp).
    
    Split `test/mockContext.js` into smaller `test/jasmine.*` modules to make easier unit tests maintenance and finally, move all `*.test.js` files under the `test/specs` folder.
    simonbrunel authored and roicos committed Aug 21, 2017
    Configuration menu
    Copy the full SHA
    77d74b2 View commit details
    Browse the repository at this point in the history
  13. Introduce unit test based on image comparison (chartjs#3988)

    Attempt to make easier the creation of unit tests that check the drawing output. Until now, this was done by checking calls on a 'fake' context, which is hard to maintain (need to update pixel values by hands) and also not reliable when optimizing code (i.e. different calls sequence but same result).
    
    As of now, it's possible to define 'auto' tests based on JSON/PNG fixtures: chart is generated from the JSON file and compared to the associated PNG image. The image diff is done using `pixelmatch`. As an example (and in preparation of the `filler` plugin), add auto tests for the line element `fill` options.
    simonbrunel authored and roicos committed Aug 21, 2017
    Configuration menu
    Copy the full SHA
    3f948ad View commit details
    Browse the repository at this point in the history
  14. Add support to fill between datasets (chartjs#4008)

    The `fill` option now accepts the index of the target dataset (number) or a string starting by "+" or "-" followed by a number representing the dataset index relative to the current one (e.g. `fill: "-2"` on dataset at index 3 will fill to dataset at index 1). It's also possible to "propagate" the filling to the target of an hidden dataset (`options.plugins.filler.propagate`). Fill boundaries `zero`, `top` and `bottom` have been deprecated and replaced by `origin`, `start` and `end`.
    
    Implementation has been moved out of the line element into a new plugin (`src/plugins/plugin.filler.js`) and does not rely anymore on the deprecated model `scaleTop`, `scaleBottom` and `scaleZero` values. Drawing Bézier splines has been refactored in the canvas helpers (note that `Chart.helpers.canvas` is now an alias of `Chart.canvasHelpers`).
    
    Add 3 new examples and extend utils with a pseudo-random number generator that can be initialized with `srand`. That makes possible to design examples starting always with the same initial data.
    simonbrunel authored and roicos committed Aug 21, 2017
    Configuration menu
    Copy the full SHA
    068ccc6 View commit details
    Browse the repository at this point in the history
  15. Correctly handle decimal display size (chartjs#4009)

    Fix the `readUsedSize` regular expression to correctly parse (truncate) pixel decimal values.
    simonbrunel authored and roicos committed Aug 21, 2017
    Configuration menu
    Copy the full SHA
    109968d View commit details
    Browse the repository at this point in the history
  16. Update the docs structure/content to use GitBook (chartjs#3751)

    Update the docs structure/content to use GitBook
    etimberg authored and roicos committed Aug 21, 2017
    Configuration menu
    Copy the full SHA
    a452fee View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    41fa8f5 View commit details
    Browse the repository at this point in the history
  18. Fix for stacked bar charts with log axes (chartjs#4010)

    * Undo fix for chartjs#3585 since it has broken the stacked bar charts when the axis has a user defined minimum value.
    
    * When a value of 0 is requested for a vertical logarithmic axis, return the bottom point
    etimberg authored and roicos committed Aug 21, 2017
    Configuration menu
    Copy the full SHA
    9031c00 View commit details
    Browse the repository at this point in the history
  19. Fix radar chart horizontal position (chartjs#4032)

    Radar chart position is not center horizontally with v2.5.0.
    
    Right and left of `furthestLimits` would be switched wrongly on
    this refactoring commit.
    chartjs@e1606f8
    shirosaki authored and roicos committed Aug 21, 2017
    Configuration menu
    Copy the full SHA
    5f06e6b View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    85e3645 View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    a031160 View commit details
    Browse the repository at this point in the history
  22. Zero line dash options (chartjs#4019)

    * Add of zero line border dash options
    * Update Readme with zero line border dash config options
    lndobryden authored and roicos committed Aug 21, 2017
    Configuration menu
    Copy the full SHA
    2b3a4fd View commit details
    Browse the repository at this point in the history
  23. Update line-customTooltips.html (Re issue chartjs#4038 )

    Add window scroll position to tooltip position calculation so they show up in the intended place instead of potentially off-screen! Moved tooltips inside the canvas parent container since they are being positioned in terms of its location
    el-ee authored and roicos committed Aug 21, 2017
    Configuration menu
    Copy the full SHA
    56801fc View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    826ce3b View commit details
    Browse the repository at this point in the history
  25. Add gulp unittest --coverage argument (chartjs#4075)

    Coverage data are now generated by running `gulp unittest` with the `--coverage` argument: unit tests are then executed a single time on Travis. The gulp `coverage` task has been removed and `karma.coverage.conf.ci.js` merged into `karma.conf.ci.js`.
    
    Update documentation with gulp commands (and remove them from `README.md`) and remove unused `config.jshintrc` (oversight from chartjs#3256). Delete `thankyou.md` which has been merged into `README.md`.
    simonbrunel authored and roicos committed Aug 21, 2017
    Configuration menu
    Copy the full SHA
    4ac523c View commit details
    Browse the repository at this point in the history
  26. Configuration menu
    Copy the full SHA
    e5b7405 View commit details
    Browse the repository at this point in the history
  27. Fixed misplaced data points on category scale

    * Fixed issue, that category scale shows data points misplaced. See chartjs#4060
    * Cleaned code
    * Fixed Irregular whitespace
    * Fixed error in case value is undefined
    * Verified that no error is thrown in case value === null
    martinzuern authored and roicos committed Aug 21, 2017
    Configuration menu
    Copy the full SHA
    e74b496 View commit details
    Browse the repository at this point in the history
  28. Update the tooltip with a new caretPadding setting. Previously this…

    … value was essentially hard coded to
    
     2 because of a typo that read it from the positioner output. Based on chartjs#3599 we agreed to make this into
    a config setting.
    etimberg authored and roicos committed Aug 21, 2017
    Configuration menu
    Copy the full SHA
    80d7412 View commit details
    Browse the repository at this point in the history
  29. Time scale improvements to improve performance and reliability

    * Make parseTime private
    * start on fixing time scale
    * Reimplement existing functionality
    * Tidy tests
    * Fix labels for non-linearly sized units
    
    Months, quarters and years have non-constant numbers of seconds. A scale that's linear WRT milliseconds produces incorrect tick labels due to the label formatting losing precision (eg year labels lose month and day so a label of 2016-12-32 displays as 2016 instead of 2017).
    
    * Re-implement tick generation
    
    As in v2.5
    tredston authored and roicos committed Aug 21, 2017
    Configuration menu
    Copy the full SHA
    a641be2 View commit details
    Browse the repository at this point in the history
  30. Configuration menu
    Copy the full SHA
    157c67a View commit details
    Browse the repository at this point in the history
  31. Adds a better error message when the chart type is incorrect. Previou…

    …sly the user got a message about `type` being undefined.
    
    This gives something that's easier to understand and debug.
    etimberg authored and roicos committed Aug 21, 2017
    Configuration menu
    Copy the full SHA
    11cca74 View commit details
    Browse the repository at this point in the history
  32. scale service - respect new weight scale option for axes ordering (ch…

    …artjs#4094)
    
    * respect new scale option 'order' when ordering scales
    
    * scale service - respect new weight scale option for axes ordering
    
    * added test for scale ordering by weight
    
    * removed trailing spaces from layout weight scale order test
    cizmiak authored and roicos committed Aug 21, 2017
    Configuration menu
    Copy the full SHA
    6f3f2a5 View commit details
    Browse the repository at this point in the history
  33. Configuration menu
    Copy the full SHA
    d0078c0 View commit details
    Browse the repository at this point in the history
  34. Configuration menu
    Copy the full SHA
    a7411bd View commit details
    Browse the repository at this point in the history
  35. Configuration menu
    Copy the full SHA
    bbce9bd View commit details
    Browse the repository at this point in the history
  36. -

    roicos committed Aug 21, 2017
    Configuration menu
    Copy the full SHA
    ce22327 View commit details
    Browse the repository at this point in the history
  37. -

    roicos committed Aug 21, 2017
    Configuration menu
    Copy the full SHA
    4ce2163 View commit details
    Browse the repository at this point in the history
  38. Configuration menu
    Copy the full SHA
    18f1758 View commit details
    Browse the repository at this point in the history