scale service - respect new weight scale option for axes ordering #4094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it'd be a good idea to have a test for this so that we know that the weights are being correctly set into the layout system |
etimberg
requested changes
Mar 31, 2017
etimberg
approved these changes
Apr 3, 2017
ericnkatz
pushed a commit
to ericnkatz/Chart.js
that referenced
this pull request
May 24, 2017
…artjs#4094) * respect new scale option 'order' when ordering scales * scale service - respect new weight scale option for axes ordering * added test for scale ordering by weight * removed trailing spaces from layout weight scale order test
roicos
pushed a commit
to roicos/Chart.js
that referenced
this pull request
Aug 21, 2017
…artjs#4094) * respect new scale option 'order' when ordering scales * scale service - respect new weight scale option for axes ordering * added test for scale ordering by weight * removed trailing spaces from layout weight scale order test
exwm
pushed a commit
to exwm/Chart.js
that referenced
this pull request
Apr 30, 2021
…artjs#4094) * respect new scale option 'order' when ordering scales * scale service - respect new weight scale option for axes ordering * added test for scale ordering by weight * removed trailing spaces from layout weight scale order test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4092
Axes with undefined weight will have weight = 0 and will be drawn first, then will be drawn ordered axes by their weight.