Update Chart.js peer dependency #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tested successfully on the ng2-charts demos
benmccann
reviewed
Dec 8, 2022
package.json
Outdated
| @@ -25,7 +25,7 @@ | |||
| "test-types": "tsc -p types/tests/" | |||
| }, | |||
| "peerDependencies": { | |||
| "chart.js": "^3.2.0" | |||
| "chart.js": "^3.2.0 || 4.0.0" | |||
There was a problem hiding this comment.
I believe that wouldn't let you use it with any other versions of 4.x like 4.0.1 . I think you probably want:
Suggested change
| "chart.js": "^3.2.0 || 4.0.0" | |
| "chart.js": ">=3.2.0" |
There was a problem hiding this comment.
Sorry, did this in a rush. I wanted to use ^3.2.0 || ^4.0.0" to be more strict and prevent this breaking in the future, but can update to >=3.0.0 if you prefer
benmccann
approved these changes
Dec 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested successfully on the ng2-charts demos
Thanks for contributing.
Description
Updated the Chart.js peer dependency to also support v4
Testing
Tested on the ng2-charts demo pages