-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Es opensearch #880
Es opensearch #880
Conversation
predicates&.filter { |o| o[:clause] == clause }&.map { |o| o[:fragment] }&.flatten || [] | ||
end | ||
|
||
def nested_preds_group(clause, attributes) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Method nested_preds_group
has 52 lines of code (exceeds 50 allowed). Consider refactoring.
} | ||
end | ||
|
||
def es_search(page = nil, per = nil) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Method es_search
has 73 lines of code (exceeds 50 allowed). Consider refactoring.
merge_mappings: true, | ||
mappings: { | ||
properties: { | ||
custom_attributes: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar blocks of code found in 2 locations. Consider refactoring.
} | ||
} | ||
}, | ||
external_profiles: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar blocks of code found in 2 locations. Consider refactoring.
743f833
to
ad61591
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 11449 lines exceeds the maximum allowed for the inline comments feature.
Code Climate has analyzed commit 177219a and detected 58 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
No description provided.