-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added eslint config and npm lint method #15
Conversation
@adamlui |
Ok added |
Cause .eslintrc.json is already here
IDK if you have any new comments cause there seems like some issue with GitHub conversation, I see the so, copy & paste you comments directly in this pull request |
Ok I will use this to communicate. eslint failed beacuse of Error: 199:11 error 'module' is not defined no-undef. It is because it doesn't know this can be used in node.js, so it doesn't know what
|
it's because the eslint config is not set correctly, if we also want to use it in node, then should add a node in the eslint config file |
Great now all we need are whatever style rules for the GitHub action. Can you make it the default ones or is it already? |
Also I don't see this ever being usable in node because that's server side, but using npm means we can still publish to npmjs.com (where they accept front end libs too) |
May use it as by |
The current GH action will use the |
Chatgpt told me to make the /.github/workflows/yml config file and that's where I inserted your rules, (and eslint check passed your last pr). Does it not depend on it anymore? If so we can remove that directory maybe |
We always need that |
And that's where your rules are, how come you said 'The current GH action will use the .eslintrc.json we defined' |
Oh never mind the style rules are not there |
current code can't pass the
npm run lint